From 84c452dea35be1515da81a2bec11a178bd001c8d Mon Sep 17 00:00:00 2001 From: Vedant Kumar Date: Fri, 15 Jul 2016 01:19:35 +0000 Subject: [llvm-cov] Clean up an awkward capture-by-reference (NFC) Writing `for (StringRef &SourceFile : ...)` is strange to begin with. Subsequently capturing "SourceFile" by reference is even stranger. Just copy the StringRef, since that's cheap to do. llvm-svn: 275515 --- llvm/tools/llvm-cov/CodeCoverage.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'llvm/tools/llvm-cov/CodeCoverage.cpp') diff --git a/llvm/tools/llvm-cov/CodeCoverage.cpp b/llvm/tools/llvm-cov/CodeCoverage.cpp index eda074cc44e..c2989f43963 100644 --- a/llvm/tools/llvm-cov/CodeCoverage.cpp +++ b/llvm/tools/llvm-cov/CodeCoverage.cpp @@ -551,8 +551,8 @@ int CodeCoverageTool::show(int argc, const char **argv, ThreadCount = std::thread::hardware_concurrency(); ThreadPool Pool(ThreadCount); - for (StringRef &SourceFile : SourceFiles) { - Pool.async([this, &SourceFile, &Coverage, &Printer, ShowFilenames] { + for (StringRef SourceFile : SourceFiles) { + Pool.async([this, SourceFile, &Coverage, &Printer, ShowFilenames] { auto View = createSourceFileView(SourceFile, *Coverage); if (!View) { deferWarning("The file '" + SourceFile.str() + "' isn't covered."); -- cgit v1.2.3