From 9bcb064f1928264a7b8f1bc0352f101e418d04e4 Mon Sep 17 00:00:00 2001 From: Andrea Di Biagio Date: Wed, 26 Oct 2016 10:28:32 +0000 Subject: [IndVarSimplify][DebugLoc] When widening the exit loop condition, correctly reuse the debug location of the original comparison. When the loop exit condition is canonicalized as a != compaison, reuse the debug location of the original (non canonical) comparison. Before this patch, the debug location of the new icmp was obtained from the loop latch terminator. This patch fixes the issue by correctly setting the IRBuilder's "current debug location" to the location of the original compare. Differential Revision: https://reviews.llvm.org/D25953 llvm-svn: 285185 --- llvm/test/DebugInfo/Generic/indvar-discriminator.ll | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'llvm/test') diff --git a/llvm/test/DebugInfo/Generic/indvar-discriminator.ll b/llvm/test/DebugInfo/Generic/indvar-discriminator.ll index 1cd47ebbe38..f27250a38c0 100644 --- a/llvm/test/DebugInfo/Generic/indvar-discriminator.ll +++ b/llvm/test/DebugInfo/Generic/indvar-discriminator.ll @@ -2,6 +2,8 @@ ; ; When the induction variable is widened by indvars, check that the debug loc ; associated with the loop increment is correctly propagated. +; Also, when the exit condition of a loop is rewritten to be a canonical != +; comparison, check that the debug loc of the orginal comparison is reused. ; ; Test case obtained from the following source code: ; @@ -19,10 +21,16 @@ ; Check that the debug location for the loop increment still refers to ; line 4, column 26, discriminator 2. ; +; Check that the canonicalized compare instruction for the loop exit +; condition still refers to line 4, column 21, discriminator 1. +; ; CHECK-LABEL: for.body: ; CHECK: [[PHI:%[0-9a-zA-Z.]+]] = phi i64 [ ; CHECK-LABEL: for.inc: ; CHECK: add nuw nsw i64 [[PHI]], 1, !dbg ![[INDVARMD:[0-9]+]] +; CHECK: icmp ne i64 %{{.+}}, %{{.+}}, !dbg ![[ICMPMD:[0-9]+]] +; CHECK-DAG: ![[ICMPMD]] = !DILocation(line: 4, column: 21, scope: ![[ICMPSCOPEMD:[0-9]+]] +; CHECK-DAG: ![[ICMPSCOPEMD]] = !DILexicalBlockFile(scope: !{{[0-9]+}}, file: !{{[0-9]+}}, discriminator: 1) ; CHECK-DAG: ![[INDVARMD]] = !DILocation(line: 4, column: 26, scope: ![[INDVARSCOPEMD:[0-9]+]]) ; CHECK-DAG: ![[INDVARSCOPEMD]] = !DILexicalBlockFile(scope: !{{[0-9]+}}, file: !{{[0-9]+}}, discriminator: 2) -- cgit v1.2.3