From 70771d8b9e8dba857bce39eee8f5d10ecc17d00f Mon Sep 17 00:00:00 2001
From: Johannes Doerfert <johannes@jdoerfert.de>
Date: Thu, 10 Oct 2019 20:32:04 -0500
Subject: [Utils] Allow update_test_checks to scrub attribute annotations

Attribute annotations on calls, e.g., #0, are not useful on their own.
This patch adds a flag to update_test_checks.py to scrub them.

Reviewed By: lebedev.ri

Differential Revision: https://reviews.llvm.org/D68851
---
 .../update_test_checks/Inputs/scrub_attrs.ll                |  8 ++++++++
 .../update_test_checks/Inputs/scrub_attrs.ll.plain.expected | 13 +++++++++++++
 .../update_test_checks/Inputs/scrub_attrs.ll.scrub.expected | 13 +++++++++++++
 .../UpdateTestChecks/update_test_checks/scrub_attrs.test    |  9 +++++++++
 4 files changed, 43 insertions(+)
 create mode 100644 llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/scrub_attrs.ll
 create mode 100644 llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/scrub_attrs.ll.plain.expected
 create mode 100644 llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/scrub_attrs.ll.scrub.expected
 create mode 100644 llvm/test/tools/UpdateTestChecks/update_test_checks/scrub_attrs.test

(limited to 'llvm/test/tools/UpdateTestChecks')

diff --git a/llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/scrub_attrs.ll b/llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/scrub_attrs.ll
new file mode 100644
index 00000000000..2733cfbce82
--- /dev/null
+++ b/llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/scrub_attrs.ll
@@ -0,0 +1,8 @@
+; RUN: opt -S < %s | FileCheck %s
+
+declare void @foo()
+
+define internal void @bar() {
+  call void @foo() readnone
+  ret void
+}
diff --git a/llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/scrub_attrs.ll.plain.expected b/llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/scrub_attrs.ll.plain.expected
new file mode 100644
index 00000000000..525e57432fb
--- /dev/null
+++ b/llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/scrub_attrs.ll.plain.expected
@@ -0,0 +1,13 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -S < %s | FileCheck %s
+
+declare void @foo()
+
+define internal void @bar() {
+; CHECK-LABEL: @bar(
+; CHECK-NEXT:    call void @foo() #0
+; CHECK-NEXT:    ret void
+;
+  call void @foo() readnone
+  ret void
+}
diff --git a/llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/scrub_attrs.ll.scrub.expected b/llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/scrub_attrs.ll.scrub.expected
new file mode 100644
index 00000000000..cbea04a0971
--- /dev/null
+++ b/llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/scrub_attrs.ll.scrub.expected
@@ -0,0 +1,13 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -S < %s | FileCheck %s
+
+declare void @foo()
+
+define internal void @bar() {
+; CHECK-LABEL: @bar(
+; CHECK-NEXT:    call void @foo()
+; CHECK-NEXT:    ret void
+;
+  call void @foo() readnone
+  ret void
+}
diff --git a/llvm/test/tools/UpdateTestChecks/update_test_checks/scrub_attrs.test b/llvm/test/tools/UpdateTestChecks/update_test_checks/scrub_attrs.test
new file mode 100644
index 00000000000..0adfb8440b3
--- /dev/null
+++ b/llvm/test/tools/UpdateTestChecks/update_test_checks/scrub_attrs.test
@@ -0,0 +1,9 @@
+## scrub_attrs test checking that update_test_checks.py works correctly
+# RUN: cp -f %S/Inputs/scrub_attrs.ll %t.ll && %update_test_checks %t.ll
+# RUN: diff -u %t.ll %S/Inputs/scrub_attrs.ll.plain.expected
+## Check that running the script again does not change the result:
+# RUN: %update_test_checks %t.ll
+# RUN: diff -u %t.ll %S/Inputs/scrub_attrs.ll.plain.expected
+## Also try the --scrub-attributes flag
+# RUN: %update_test_checks %t.ll --scrub-attributes
+# RUN: diff -u %t.ll %S/Inputs/scrub_attrs.ll.scrub.expected
-- 
cgit v1.2.3