From b537b946b82f7e2c52ad16cf3fbff93345ee4993 Mon Sep 17 00:00:00 2001 From: Vedant Kumar Date: Sat, 19 Jan 2019 02:46:22 +0000 Subject: [MergeFunc] Allow merging identical vararg functions using aliases Thanks to Nikita Popov for pointing out this missed case. This is a follow-up to r351411, which disabled function merging for vararg functions outright due to a miscompile (see llvm.org/PR40345). Differential Revision: https://reviews.llvm.org/D56865 llvm-svn: 351624 --- llvm/test/Transforms/MergeFunc/va_arg.ll | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'llvm/test/Transforms') diff --git a/llvm/test/Transforms/MergeFunc/va_arg.ll b/llvm/test/Transforms/MergeFunc/va_arg.ll index eb49a7286ff..1a48a6395ed 100644 --- a/llvm/test/Transforms/MergeFunc/va_arg.ll +++ b/llvm/test/Transforms/MergeFunc/va_arg.ll @@ -1,14 +1,18 @@ ; RUN: opt -S -mergefunc < %s | FileCheck %s +; RUN: opt -S -mergefunc -mergefunc-use-aliases < %s | FileCheck %s -check-prefix=ALIAS target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" target triple = "x86_64-unknown-linux-gnu" +; ALIAS: @_Z9simple_vaPKcz = unnamed_addr alias void (i8*, ...), void (i8*, ...)* @_Z10simple_va2PKcz +; ALIAS-NOT: @_Z9simple_vaPKcz + %struct.__va_list_tag = type { i32, i32, i8*, i8* } ; CHECK-LABEL: define {{.*}}@_Z9simple_vaPKcz ; CHECK: call void @llvm.va_start ; CHECK: call void @llvm.va_end -define dso_local void @_Z9simple_vaPKcz(i8* nocapture readnone, ...) local_unnamed_addr { +define dso_local void @_Z9simple_vaPKcz(i8* nocapture readnone, ...) unnamed_addr { %2 = alloca [1 x %struct.__va_list_tag], align 16 %3 = bitcast [1 x %struct.__va_list_tag]* %2 to i8* call void @llvm.va_start(i8* nonnull %3) @@ -54,7 +58,7 @@ declare void @llvm.va_end(i8*) ; CHECK-LABEL: define {{.*}}@_Z10simple_va2PKcz ; CHECK: call void @llvm.va_start ; CHECK: call void @llvm.va_end -define dso_local void @_Z10simple_va2PKcz(i8* nocapture readnone, ...) local_unnamed_addr { +define dso_local void @_Z10simple_va2PKcz(i8* nocapture readnone, ...) unnamed_addr { %2 = alloca [1 x %struct.__va_list_tag], align 16 %3 = bitcast [1 x %struct.__va_list_tag]* %2 to i8* call void @llvm.va_start(i8* nonnull %3) -- cgit v1.2.3