From 17ee427ef35d7521f90f28a7db83fddb4aadd475 Mon Sep 17 00:00:00 2001 From: Kuba Mracek Date: Tue, 15 Aug 2017 20:29:24 +0000 Subject: [llvm] Get rid of "%T" expansions The %T lit expansion expands to a common directory shared between all the tests in the same directory, which is unexpected and unintuitive, and more importantly, it's been a source of subtle race conditions and flaky tests. In https://reviews.llvm.org/D35396, it was agreed that it would be best to simply ban %T and only keep %t, which is unique to each test. When a test needs a temporary directory, it can just create one using mkdir %t. This patch removes %T in llvm. Differential Revision: https://reviews.llvm.org/D36495 llvm-svn: 310953 --- llvm/test/LibDriver/infer-output-path.test | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) (limited to 'llvm/test/LibDriver/infer-output-path.test') diff --git a/llvm/test/LibDriver/infer-output-path.test b/llvm/test/LibDriver/infer-output-path.test index 7a1bbcbbd18..c63b0abdf6e 100644 --- a/llvm/test/LibDriver/infer-output-path.test +++ b/llvm/test/LibDriver/infer-output-path.test @@ -1,15 +1,16 @@ -RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %T/a.obj %S/Inputs/a.s -RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %T/b.o %S/Inputs/b.s -RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %T/c %S/Inputs/b.s +RUN: rm -rf %t && mkdir -p %t +RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %t/a.obj %S/Inputs/a.s +RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %t/b.o %S/Inputs/b.s +RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %t/c %S/Inputs/b.s -RUN: rm -f %T/a.lib -RUN: llvm-lib %T/a.obj -RUN: test -e %T/a.lib +RUN: rm -f %t/a.lib +RUN: llvm-lib %t/a.obj +RUN: test -e %t/a.lib -RUN: rm -f %T/b.lib -RUN: llvm-lib /libpath:%T b.o -RUN: test -e %T/b.lib +RUN: rm -f %t/b.lib +RUN: llvm-lib /libpath:%t b.o +RUN: test -e %t/b.lib -RUN: rm -f %T/c.lib -RUN: llvm-lib /libpath:%T c -RUN: test -e %T/c.lib +RUN: rm -f %t/c.lib +RUN: llvm-lib /libpath:%t c +RUN: test -e %t/c.lib -- cgit v1.2.3