From 820aac1c783e39c863bb99e33d5c98fd7f06c8e4 Mon Sep 17 00:00:00 2001 From: Michael Gottesman Date: Thu, 3 Jan 2013 08:18:30 +0000 Subject: Revert "Mark DIV/IDIV instructions hasSideEffects=1 because they can trap when dividing by 0. This is needed to keep early if conversion from moving them across basic blocks." This reverts commit r171461 since it breaks the following tests: Clang :: Analysis/outofbound-notwork.c Clang :: Analysis/string-fail.c Clang :: CXX/basic/basic.lookup/basic.lookup.qual/p6-0x.cpp Clang :: CXX/basic/basic.lookup/basic.lookup.unqual/p15.cpp Clang :: CXX/dcl.dcl/dcl.spec/dcl.fct.spec/p4.cpp Clang :: CXX/dcl.dcl/dcl.spec/dcl.stc/p10.cpp Clang :: CXX/temp/temp.param/p14.cpp Clang :: CXX/temp/temp.res/temp.dep.res/temp.point/p1.cpp Clang :: CodeGen/2009-02-13-zerosize-union-field-ppc.c Clang :: CodeGen/blocks-2.c Clang :: CodeGen/libcalls-d.c Clang :: CodeGen/libcalls-ld.c Clang :: CodeGenCXX/conversion-function.cpp Clang :: CodeGenCXX/debug-info-limit-type.cpp Clang :: CodeGenCXX/inheriting-constructor.cpp Clang :: FixIt/fixit-errors.c Clang :: FixIt/fixit-pmem.cpp Clang :: Modules/namespaces.cpp Clang :: PCH/changed-files.c Clang :: PCH/pr4489.c Clang :: PCH/source-manager-stack.c Clang :: Parser/cxx-ambig-decl-expr-xfail.cpp Clang :: SemaCXX/switch-implicit-fallthrough-cxx98.cpp Clang :: SemaTemplate/instantiate-function-1.mm llvm-svn: 171466 --- llvm/test/CodeGen/X86/early-ifcvt.ll | 32 -------------------------------- 1 file changed, 32 deletions(-) (limited to 'llvm/test/CodeGen/X86/early-ifcvt.ll') diff --git a/llvm/test/CodeGen/X86/early-ifcvt.ll b/llvm/test/CodeGen/X86/early-ifcvt.ll index b3a20c3ee0b..2e1852d3e3a 100644 --- a/llvm/test/CodeGen/X86/early-ifcvt.ll +++ b/llvm/test/CodeGen/X86/early-ifcvt.ll @@ -142,35 +142,3 @@ save_state_and_return: } declare void @BZ2_bz__AssertH__fail() - - -; Make sure we don't speculate on div/idiv instructions -; CHECK: test_idiv -; CHECK-NOT: cmov -define i32 @test_idiv(i32 %a, i32 %b) nounwind uwtable readnone ssp { - %1 = icmp eq i32 %b, 0 - br i1 %1, label %4, label %2 - -;