From 92dadc0bca8027635daf28ec87cae2bbbe41990b Mon Sep 17 00:00:00 2001 From: Daniel Cederman Date: Mon, 27 Aug 2018 07:14:53 +0000 Subject: [Sparc] Custom bitcast between f64 and v2i32 Summary: Currently bitcasting constants from f64 to v2i32 is done by storing the value to the stack and then loading it again. This is not necessary, but seems to happen because v2i32 is a valid type for Sparc V8. If it had not been legal, we would have gotten help from the type legalizer. This patch tries to do the same work as the legalizer would have done by bitcasting the floating point constant and splitting the value up into a vector of two i32 values. Reviewers: venkatra, jyknight Reviewed By: jyknight Subscribers: glaubitz, fedor.sergeev, jrtc27, llvm-commits Differential Revision: https://reviews.llvm.org/D49219 llvm-svn: 340723 --- llvm/test/CodeGen/SPARC/float-constants.ll | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) (limited to 'llvm/test/CodeGen/SPARC/float-constants.ll') diff --git a/llvm/test/CodeGen/SPARC/float-constants.ll b/llvm/test/CodeGen/SPARC/float-constants.ll index b3686ebdf44..8b38eee7001 100644 --- a/llvm/test/CodeGen/SPARC/float-constants.ll +++ b/llvm/test/CodeGen/SPARC/float-constants.ll @@ -1,14 +1,14 @@ ; RUN: llc < %s -march=sparc | FileCheck %s - -; TODO: actually fix the codegen to be optimal. At least we don't -; crash for now, though... +; RUN: llc < %s -march=sparcel | FileCheck %s --check-prefix=CHECK-LE ;; Bitcast should not do a runtime conversion, but rather emit a ;; constant into integer registers directly. ; CHECK-LABEL: bitcast: -; TODO-CHECK: sethi 1049856, %o0 -; TODO-CHECK: sethi 0, %o1 +; CHECK: sethi 1049856, %o0 +; CHECK: mov %g0, %o1 +; CHECK-LE: mov %g0, %o0 +; CHECK-LE: sethi 1049856, %o1 define <2 x i32> @bitcast() { %1 = bitcast double 5.0 to <2 x i32> ret <2 x i32> %1 @@ -18,8 +18,10 @@ define <2 x i32> @bitcast() { ;; registers) ; CHECK-LABEL: test_call -; TODO-CHECK: sethi 1049856, %o0 -; TODO-CHECK: sethi 0, %o1 +; CHECK: sethi 1049856, %o0 +; CHECK: mov %g0, %o1 +; CHECK-LE: mov %g0, %o0 +; CHECK-LE: sethi 1049856, %o1 declare void @a(double) define void @test_call() { call void @a(double 5.0) @@ -32,8 +34,12 @@ define void @test_call() { ;; due to an earlier broken workaround for this issue.) ; CHECK-LABEL: test_intrins_call -; TODO-CHECK: sethi 1049856, %o0 -; TODO-CHECK: sethi 0, %o1 +; CHECK: sethi 1048576, %o0 +; CHECK: mov %g0, %o1 +; CHECK: mov %o0, %o2 +; CHECK: mov %o1, %o3 +; CHECK-LE: mov %g0, %o0 +; CHECK-LE: sethi 1048576, %o1 declare double @llvm.pow.f64(double, double) define double @test_intrins_call() { %1 = call double @llvm.pow.f64(double 2.0, double 2.0) -- cgit v1.2.3