From 0dc6c249bffac9f23a605ce4e42a84341da3ddbd Mon Sep 17 00:00:00 2001 From: cdevadas Date: Fri, 10 Jan 2020 22:23:27 +0530 Subject: [AMDGPU] Invert the handling of skip insertion. The current implementation of skip insertion (SIInsertSkip) makes it a mandatory pass required for correctness. Initially, the idea was to have an optional pass. This patch inserts the s_cbranch_execz upfront during SILowerControlFlow to skip over the sections of code when no lanes are active. Later, SIRemoveShortExecBranches removes the skips for short branches, unless there is a sideeffect and the skip branch is really necessary. This new pass will replace the handling of skip insertion in the existing SIInsertSkip Pass. Differential revision: https://reviews.llvm.org/D68092 --- llvm/test/CodeGen/AMDGPU/si-annotate-cf-noloop.ll | 2 -- 1 file changed, 2 deletions(-) (limited to 'llvm/test/CodeGen/AMDGPU/si-annotate-cf-noloop.ll') diff --git a/llvm/test/CodeGen/AMDGPU/si-annotate-cf-noloop.ll b/llvm/test/CodeGen/AMDGPU/si-annotate-cf-noloop.ll index a99d18147cc..e854c089268 100644 --- a/llvm/test/CodeGen/AMDGPU/si-annotate-cf-noloop.ll +++ b/llvm/test/CodeGen/AMDGPU/si-annotate-cf-noloop.ll @@ -40,8 +40,6 @@ bb5: ; preds = %bb3, %bb1 ; GCN: load_dwordx4 ; GCN: v_cmp_nlt_f32 ; GCN: s_and_saveexec_b64 -; GCN: ; mask branch [[UNIFIED_RET:BB[0-9]+_[0-9]+]] -; GCN-NEXT: [[UNIFIED_RET]]: ; GCN-NEXT: s_endpgm ; GCN: .Lfunc_end define amdgpu_kernel void @annotate_ret_noloop(<4 x float> addrspace(1)* noalias nocapture readonly %arg) #0 { -- cgit v1.2.3