From e7d4cd639bcd21aebd0d5f9866d9e9ca717297b1 Mon Sep 17 00:00:00 2001 From: Sylvestre Ledru Date: Tue, 26 Sep 2017 11:56:43 +0000 Subject: Don't move llvm.localescape outside the entry block in the GCOV profiling pass Summary: This fixes https://bugs.llvm.org/show_bug.cgi?id=34714. Patch by Marco Castelluccio Reviewers: rnk Reviewed By: rnk Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D38224 llvm-svn: 314201 --- llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) (limited to 'llvm/lib') diff --git a/llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp b/llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp index b2033536ac8..3154c1939ea 100644 --- a/llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp +++ b/llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp @@ -502,6 +502,16 @@ static bool functionHasLines(Function &F) { return false; } +static bool shouldKeepInEntry(BasicBlock::iterator It) { + if (isa(*It)) return true; + if (isa(*It)) return true; + if (auto *II = dyn_cast(It)) { + if (II->getIntrinsicID() == llvm::Intrinsic::localescape) return true; + } + + return false; +} + void GCOVProfiler::emitProfileNotes() { NamedMDNode *CU_Nodes = M->getNamedMetadata("llvm.dbg.cu"); if (!CU_Nodes) return; @@ -537,7 +547,7 @@ void GCOVProfiler::emitProfileNotes() { // single successor, so split the entry block to make sure of that. BasicBlock &EntryBlock = F.getEntryBlock(); BasicBlock::iterator It = EntryBlock.begin(); - while (isa(*It) || isa(*It)) + while (shouldKeepInEntry(It)) ++It; EntryBlock.splitBasicBlock(It); -- cgit v1.2.3