From e69ae76b20f1c417a21524b630aeac34c82fd5fc Mon Sep 17 00:00:00 2001 From: JF Bastien Date: Thu, 9 Aug 2018 18:28:54 +0000 Subject: [NFC] Remove magic bool param in RAUW Use an enum class instead. llvm-svn: 339366 --- llvm/lib/IR/Value.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'llvm/lib') diff --git a/llvm/lib/IR/Value.cpp b/llvm/lib/IR/Value.cpp index 295d6ecf0db..6dc48ad97cc 100644 --- a/llvm/lib/IR/Value.cpp +++ b/llvm/lib/IR/Value.cpp @@ -405,7 +405,7 @@ static bool contains(Value *Expr, Value *V) { } #endif // NDEBUG -void Value::doRAUW(Value *New, bool NoMetadata) { +void Value::doRAUW(Value *New, ReplaceMetadataUses ReplaceMetaUses) { assert(New && "Value::replaceAllUsesWith() is invalid!"); assert(!contains(New, this) && "this->replaceAllUsesWith(expr(this)) is NOT valid!"); @@ -415,7 +415,7 @@ void Value::doRAUW(Value *New, bool NoMetadata) { // Notify all ValueHandles (if present) that this value is going away. if (HasValueHandle) ValueHandleBase::ValueIsRAUWd(this, New); - if (!NoMetadata && isUsedByMetadata()) + if (ReplaceMetaUses == ReplaceMetadataUses::Yes && isUsedByMetadata()) ValueAsMetadata::handleRAUW(this, New); while (!materialized_use_empty()) { @@ -437,11 +437,11 @@ void Value::doRAUW(Value *New, bool NoMetadata) { } void Value::replaceAllUsesWith(Value *New) { - doRAUW(New, false /* NoMetadata */); + doRAUW(New, ReplaceMetadataUses::Yes); } void Value::replaceNonMetadataUsesWith(Value *New) { - doRAUW(New, true /* NoMetadata */); + doRAUW(New, ReplaceMetadataUses::No); } // Like replaceAllUsesWith except it does not handle constants or basic blocks. -- cgit v1.2.3