From 4e9db1beff1cb17d7121e66c0257fa0e68fe20b6 Mon Sep 17 00:00:00 2001 From: Alexey Bataev Date: Tue, 22 Jan 2019 17:43:37 +0000 Subject: [DEBUGINFO, NVPTX] Enable support for the debug info on NVPTX target. Summary: Enable full support for the debug info. Reviewers: echristo Subscribers: jholewinski, aprantl, JDevlieghere, llvm-commits Differential Revision: https://reviews.llvm.org/D46189 llvm-svn: 351846 --- llvm/lib/Target/NVPTX/MCTargetDesc/NVPTXMCAsmInfo.cpp | 9 ++++----- llvm/lib/Target/NVPTX/MCTargetDesc/NVPTXTargetStreamer.cpp | 5 ++--- llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp | 6 ++---- 3 files changed, 8 insertions(+), 12 deletions(-) (limited to 'llvm/lib') diff --git a/llvm/lib/Target/NVPTX/MCTargetDesc/NVPTXMCAsmInfo.cpp b/llvm/lib/Target/NVPTX/MCTargetDesc/NVPTXMCAsmInfo.cpp index 52110b9ddfd..556745825a1 100644 --- a/llvm/lib/Target/NVPTX/MCTargetDesc/NVPTXMCAsmInfo.cpp +++ b/llvm/lib/Target/NVPTX/MCTargetDesc/NVPTXMCAsmInfo.cpp @@ -37,12 +37,11 @@ NVPTXMCAsmInfo::NVPTXMCAsmInfo(const Triple &TheTriple) { HiddenDeclarationVisibilityAttr = HiddenVisibilityAttr = MCSA_Invalid; ProtectedVisibilityAttr = MCSA_Invalid; - // FIXME: remove comment once debug info is properly supported. - Data8bitsDirective = "// .b8 "; + Data8bitsDirective = ".b8 "; Data16bitsDirective = nullptr; // not supported - Data32bitsDirective = "// .b32 "; - Data64bitsDirective = "// .b64 "; - ZeroDirective = "// .b8"; + Data32bitsDirective = ".b32 "; + Data64bitsDirective = ".b64 "; + ZeroDirective = ".b8"; AsciiDirective = nullptr; // not supported AscizDirective = nullptr; // not supported SupportsQuotedNames = false; diff --git a/llvm/lib/Target/NVPTX/MCTargetDesc/NVPTXTargetStreamer.cpp b/llvm/lib/Target/NVPTX/MCTargetDesc/NVPTXTargetStreamer.cpp index 7e978869133..f2e62eb6298 100644 --- a/llvm/lib/Target/NVPTX/MCTargetDesc/NVPTXTargetStreamer.cpp +++ b/llvm/lib/Target/NVPTX/MCTargetDesc/NVPTXTargetStreamer.cpp @@ -81,10 +81,9 @@ void NVPTXTargetStreamer::changeSection(const MCSection *CurSection, raw_ostream &OS) { assert(!SubSection && "SubSection is not null!"); const MCObjectFileInfo *FI = getStreamer().getContext().getObjectFileInfo(); - // FIXME: remove comment once debug info is properly supported. // Emit closing brace for DWARF sections only. if (isDwarfSection(FI, CurSection)) - OS << "//\t}\n"; + OS << "\t}\n"; if (isDwarfSection(FI, Section)) { // Emit DWARF .file directives in the outermost scope. outputDwarfFileDirectives(); @@ -92,7 +91,7 @@ void NVPTXTargetStreamer::changeSection(const MCSection *CurSection, Section->PrintSwitchToSection(*getStreamer().getContext().getAsmInfo(), FI->getTargetTriple(), OS, SubSection); // DWARF sections are enclosed into braces - emit the open one. - OS << "//\t{\n"; + OS << "\t{\n"; } } diff --git a/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp b/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp index f07266d1fae..cd0be388f9a 100644 --- a/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp +++ b/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp @@ -901,9 +901,8 @@ void NVPTXAsmPrinter::emitHeader(Module &M, raw_ostream &O, if (HasFullDebugInfo) break; } - // FIXME: remove comment once debug info is properly supported. if (MMI && MMI->hasDebugInfo() && HasFullDebugInfo) - O << "//, debug"; + O << ", debug"; O << "\n"; @@ -954,10 +953,9 @@ bool NVPTXAsmPrinter::doFinalization(Module &M) { clearAnnotationCache(&M); delete[] gv_array; - // FIXME: remove comment once debug info is properly supported. // Close the last emitted section if (HasDebugInfo) - OutStreamer->EmitRawText("//\t}"); + OutStreamer->EmitRawText("\t}"); // Output last DWARF .file directives, if any. static_cast(OutStreamer->getTargetStreamer()) -- cgit v1.2.3