From e17c5d0e594a930d557fd6a361c33ca57cad5b6a Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Mon, 1 Aug 2005 16:52:50 +0000 Subject: ConstantInt::get only works for arguments < 128. SimplifyLibCalls probably has to be audited to make sure it does not make this mistake elsewhere. Also, if this code knows that the type will be unsigned, obviously one arm of this is dead. Reid, can you take a look into this further? llvm-svn: 22566 --- llvm/lib/Transforms/IPO/SimplifyLibCalls.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'llvm/lib/Transforms') diff --git a/llvm/lib/Transforms/IPO/SimplifyLibCalls.cpp b/llvm/lib/Transforms/IPO/SimplifyLibCalls.cpp index 754143bea7f..99675b3cb35 100644 --- a/llvm/lib/Transforms/IPO/SimplifyLibCalls.cpp +++ b/llvm/lib/Transforms/IPO/SimplifyLibCalls.cpp @@ -962,8 +962,12 @@ struct StrLenOptimization : public LibCallOptimization return false; // strlen("xyz") -> 3 (for example) - ci->replaceAllUsesWith( - ConstantInt::get(SLC.getTargetData()->getIntPtrType(),len)); + const Type *Ty = SLC.getTargetData()->getIntPtrType(); + if (Ty->isSigned()) + ci->replaceAllUsesWith(ConstantSInt::get(Ty, len)); + else + ci->replaceAllUsesWith(ConstantUInt::get(Ty, len)); + ci->eraseFromParent(); return true; } -- cgit v1.2.3