From 04386d8e3de6c9fe79d0f911841ff94368bd61cc Mon Sep 17 00:00:00 2001 From: Vedant Kumar Date: Fri, 9 Feb 2018 19:19:55 +0000 Subject: [Utils] Salvage debug info from dead 'or' instructions Extend salvageDebugInfo to preserve the debug info from a dead 'or' with a constant. Patch by Ismail Badawi! Differential Revision: https://reviews.llvm.org/D43129 llvm-svn: 324764 --- llvm/lib/Transforms/Utils/Local.cpp | 31 ++++++++++++++++++++++++------- 1 file changed, 24 insertions(+), 7 deletions(-) (limited to 'llvm/lib/Transforms') diff --git a/llvm/lib/Transforms/Utils/Local.cpp b/llvm/lib/Transforms/Utils/Local.cpp index 337ee0e9ef5..39169f931b7 100644 --- a/llvm/lib/Transforms/Utils/Local.cpp +++ b/llvm/lib/Transforms/Utils/Local.cpp @@ -1497,16 +1497,27 @@ void llvm::salvageDebugInfo(Instruction &I) { return MetadataAsValue::get(I.getContext(), ValueAsMetadata::get(V)); }; - auto applyOffset = [&](DbgInfoIntrinsic *DII, uint64_t Offset) { + auto doSalvage = [&](DbgInfoIntrinsic *DII, SmallVectorImpl &Ops) { auto *DIExpr = DII->getExpression(); - DIExpr = DIExpression::prepend(DIExpr, DIExpression::NoDeref, Offset, - DIExpression::NoDeref, - DIExpression::WithStackValue); + DIExpr = DIExpression::doPrepend(DIExpr, Ops, + DIExpression::WithStackValue); DII->setOperand(0, wrapMD(I.getOperand(0))); DII->setOperand(2, MetadataAsValue::get(I.getContext(), DIExpr)); DEBUG(dbgs() << "SALVAGE: " << *DII << '\n'); }; + auto applyOffset = [&](DbgInfoIntrinsic *DII, uint64_t Offset) { + SmallVector Ops; + DIExpression::appendOffset(Ops, Offset); + doSalvage(DII, Ops); + }; + + auto applyOps = [&](DbgInfoIntrinsic *DII, + std::initializer_list Opcodes) { + SmallVector Ops(Opcodes); + doSalvage(DII, Ops); + }; + if (isa(&I) || isa(&I)) { // Bitcasts are entirely irrelevant for debug info. Rewrite dbg.value, // dbg.addr, and dbg.declare to use the cast's source. @@ -1525,11 +1536,17 @@ void llvm::salvageDebugInfo(Instruction &I) { for (auto *DII : DbgUsers) applyOffset(DII, Offset.getSExtValue()); } else if (auto *BI = dyn_cast(&I)) { - if (BI->getOpcode() == Instruction::Add) + if (BI->getOpcode() == Instruction::Add || + BI->getOpcode() == Instruction::Or) if (auto *ConstInt = dyn_cast(I.getOperand(1))) - if (ConstInt->getBitWidth() <= 64) + if (ConstInt->getBitWidth() <= 64) { + uint64_t Val = ConstInt->getSExtValue(); for (auto *DII : DbgUsers) - applyOffset(DII, ConstInt->getSExtValue()); + if (BI->getOpcode() == Instruction::Add) + applyOffset(DII, Val); + else if (BI->getOpcode() == Instruction::Or) + applyOps(DII, {dwarf::DW_OP_constu, Val, dwarf::DW_OP_or}); + } } else if (isa(&I)) { MetadataAsValue *AddrMD = wrapMD(I.getOperand(0)); for (auto *DII : DbgUsers) { -- cgit v1.2.3