From e109655c902f6e381348c5874512b4897bedff8f Mon Sep 17 00:00:00 2001 From: Alexey Bataev Date: Fri, 28 Jul 2017 20:11:16 +0000 Subject: [SLP] Allow vectorization of the instruction from the same basic blocks only, NFC. Summary: After some changes in SLP vectorizer we missed some additional checks to limit the instructions for vectorization. We should not perform analysis of the instructions if the parent of instruction is not the same as the parent of the first instruction in the tree or it was analyzed already. Subscribers: mzolotukhin Differential Revision: https://reviews.llvm.org/D34881 llvm-svn: 309425 --- llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) (limited to 'llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp') diff --git a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp index 9931c78fcbc..a0da1a15074 100644 --- a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp +++ b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp @@ -4776,7 +4776,7 @@ static bool tryToVectorizeHorReductionOrInstOperands( if (!Root) return false; - if (Root->getParent() != BB) + if (Root->getParent() != BB || isa(Root)) return false; // Start analysis starting from Root instruction. If horizontal reduction is // found, try to vectorize it. If it is not a horizontal reduction or @@ -4797,7 +4797,7 @@ static bool tryToVectorizeHorReductionOrInstOperands( if (!V) continue; auto *Inst = dyn_cast(V); - if (!Inst || isa(Inst)) + if (!Inst) continue; if (auto *BI = dyn_cast(Inst)) { HorizontalReduction HorRdx; @@ -4831,9 +4831,14 @@ static bool tryToVectorizeHorReductionOrInstOperands( } // Try to vectorize operands. + // Continue analysis for the instruction from the same basic block only to + // save compile time. if (++Level < RecursionMaxDepth) for (auto *Op : Inst->operand_values()) - Stack.emplace_back(Op, Level); + if (VisitedInstrs.insert(Op).second) + if (auto *I = dyn_cast(Op)) + if (!isa(Inst) && I->getParent() == BB) + Stack.emplace_back(Op, Level); } return Res; } -- cgit v1.2.3