From 835facd863ca94f28e32f4fd7a132e470d04e2f8 Mon Sep 17 00:00:00 2001 From: Michael Kuperstein Date: Tue, 28 Jun 2016 00:54:12 +0000 Subject: [PM] Normalize FIXMEs for missing PreserveCFG to have the same wording. llvm-svn: 273974 --- llvm/lib/Transforms/Utils/LCSSA.cpp | 3 +-- llvm/lib/Transforms/Utils/Mem2Reg.cpp | 6 +----- 2 files changed, 2 insertions(+), 7 deletions(-) (limited to 'llvm/lib/Transforms/Utils') diff --git a/llvm/lib/Transforms/Utils/LCSSA.cpp b/llvm/lib/Transforms/Utils/LCSSA.cpp index 029164dbb46..251086937c0 100644 --- a/llvm/lib/Transforms/Utils/LCSSA.cpp +++ b/llvm/lib/Transforms/Utils/LCSSA.cpp @@ -340,8 +340,7 @@ PreservedAnalyses LCSSAPass::run(Function &F, AnalysisManager &AM) { if (!formLCSSAOnAllLoops(&LI, DT, SE)) return PreservedAnalyses::all(); - // FIXME: There is no setPreservesCFG in the new PM. When that becomes - // available, it should be used here. + // FIXME: This should also 'preserve the CFG'. PreservedAnalyses PA; PA.preserve(); PA.preserve(); diff --git a/llvm/lib/Transforms/Utils/Mem2Reg.cpp b/llvm/lib/Transforms/Utils/Mem2Reg.cpp index d26a603573d..1419254bcb4 100644 --- a/llvm/lib/Transforms/Utils/Mem2Reg.cpp +++ b/llvm/lib/Transforms/Utils/Mem2Reg.cpp @@ -59,11 +59,7 @@ PreservedAnalyses PromotePass::run(Function &F, AnalysisManager &AM) { if (!promoteMemoryToRegister(F, DT, AC)) return PreservedAnalyses::all(); - // FIXME: This pass should preserve the CFG. - // There's currently no way to do it in the new PM. - // In the old PM this pass preserved a fair amount of "orthogonal" - // transformation passes. This concept has no sense in the new PM, - // therefore we don't preserve them here. + // FIXME: This should also 'preserve the CFG'. return PreservedAnalyses::none(); } -- cgit v1.2.3