From 8c209aa8779de57771b64896f805e14cc0016dcd Mon Sep 17 00:00:00 2001 From: Matthias Braun Date: Sat, 28 Jan 2017 02:02:38 +0000 Subject: Cleanup dump() functions. We had various variants of defining dump() functions in LLVM. Normalize them (this should just consistently implement the things discussed in http://lists.llvm.org/pipermail/cfe-dev/2014-January/034323.html For reference: - Public headers should just declare the dump() method but not use LLVM_DUMP_METHOD or #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) - The definition of a dump method should look like this: #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) LLVM_DUMP_METHOD void MyClass::dump() { // print stuff to dbgs()... } #endif llvm-svn: 293359 --- llvm/lib/Transforms/Utils/MemorySSA.cpp | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'llvm/lib/Transforms/Utils/MemorySSA.cpp') diff --git a/llvm/lib/Transforms/Utils/MemorySSA.cpp b/llvm/lib/Transforms/Utils/MemorySSA.cpp index e93bc0ecc5b..dbf54309053 100644 --- a/llvm/lib/Transforms/Utils/MemorySSA.cpp +++ b/llvm/lib/Transforms/Utils/MemorySSA.cpp @@ -1888,10 +1888,11 @@ void MemorySSA::print(raw_ostream &OS) const { F.print(OS, &Writer); } -void MemorySSA::dump() const { - MemorySSAAnnotatedWriter Writer(this); - F.print(dbgs(), &Writer); +#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) +LLVM_DUMP_METHOD void MemorySSA::dump() const { + print(dbgs()); } +#endif void MemorySSA::verifyMemorySSA() const { verifyDefUses(F); @@ -2161,8 +2162,11 @@ void MemoryUse::print(raw_ostream &OS) const { } void MemoryAccess::dump() const { + // Cannot completely remove virtual function even in release mode. +#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) print(dbgs()); dbgs() << "\n"; +#endif } char MemorySSAPrinterLegacyPass::ID = 0; -- cgit v1.2.3