From 0bc0eef71c09ddc0c7ef73a0dc54a7875c965c03 Mon Sep 17 00:00:00 2001 From: David Majnemer Date: Sat, 15 Aug 2015 02:46:08 +0000 Subject: [IR] Give catchret an optional 'return value' operand Some personality routines require funclet exit points to be clearly marked, this is done by producing a token at the funclet pad and consuming it at the corresponding ret instruction. CleanupReturnInst already had a spot for this operand but CatchReturnInst did not. Other personality routines don't need to use this which is why it has been made optional. llvm-svn: 245149 --- llvm/lib/Transforms/Utils/CodeExtractor.cpp | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) (limited to 'llvm/lib/Transforms/Utils/CodeExtractor.cpp') diff --git a/llvm/lib/Transforms/Utils/CodeExtractor.cpp b/llvm/lib/Transforms/Utils/CodeExtractor.cpp index 896cff1bae9..e76a9d4ba2d 100644 --- a/llvm/lib/Transforms/Utils/CodeExtractor.cpp +++ b/llvm/lib/Transforms/Utils/CodeExtractor.cpp @@ -560,14 +560,20 @@ emitCallAndSwitchStatement(Function *newFunction, BasicBlock *codeReplacer, // Restore values just before we exit Function::arg_iterator OAI = OutputArgBegin; for (unsigned out = 0, e = outputs.size(); out != e; ++out) { - // For an invoke, the normal destination is the only one that is - // dominated by the result of the invocation + // For an invoke/catchpad, the normal destination is the only one + // that is dominated by the result of the invocation BasicBlock *DefBlock = cast(outputs[out])->getParent(); bool DominatesDef = true; - if (InvokeInst *Invoke = dyn_cast(outputs[out])) { - DefBlock = Invoke->getNormalDest(); + BasicBlock *NormalDest = nullptr; + if (auto *Invoke = dyn_cast(outputs[out])) + NormalDest = Invoke->getNormalDest(); + if (auto *CatchPad = dyn_cast(outputs[out])) + NormalDest = CatchPad->getNormalDest(); + + if (NormalDest) { + DefBlock = NormalDest; // Make sure we are looking at the original successor block, not // at a newly inserted exit block, which won't be in the dominator -- cgit v1.2.3