From fc31b58eff9da4447f9f332f07de3cd07ab4b56c Mon Sep 17 00:00:00 2001 From: Sanjay Patel Date: Mon, 25 Nov 2019 11:11:12 -0500 Subject: [InstCombine] simplify code for shuffle mask canonicalization; NFC We never use the local 'Mask' before returning, so that was dead code. --- llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp') diff --git a/llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp b/llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp index 2f9d342daca..fd31f524e5c 100644 --- a/llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp +++ b/llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp @@ -1900,13 +1900,11 @@ Instruction *InstCombiner::visitShuffleVectorInst(ShuffleVectorInst &SVI) { continue; } - if (Mask[i] < (int)LHSWidth && isa(LHS)) { - Mask[i] = -1; // Turn into undef. + // Change select of undef to undef mask element or force to LHS. + if (Mask[i] < (int)LHSWidth && isa(LHS)) Elts.push_back(UndefValue::get(Int32Ty)); - } else { - Mask[i] = Mask[i] % LHSWidth; // Force to LHS. - Elts.push_back(ConstantInt::get(Int32Ty, Mask[i])); - } + else + Elts.push_back(ConstantInt::get(Int32Ty, Mask[i] % LHSWidth)); } SVI.setOperand(0, SVI.getOperand(1)); SVI.setOperand(1, UndefValue::get(RHS->getType())); -- cgit v1.2.3