From ab16577adef66724af1f31440cbe535522fdcf6d Mon Sep 17 00:00:00 2001 From: Devang Patel Date: Fri, 6 Mar 2009 00:21:00 +0000 Subject: Do not let debug info prevert globalopt from shriking a global vars to boolean. llvm-svn: 66224 --- llvm/lib/Transforms/IPO/GlobalOpt.cpp | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) (limited to 'llvm/lib/Transforms/IPO/GlobalOpt.cpp') diff --git a/llvm/lib/Transforms/IPO/GlobalOpt.cpp b/llvm/lib/Transforms/IPO/GlobalOpt.cpp index 9284500a865..69753b399d1 100644 --- a/llvm/lib/Transforms/IPO/GlobalOpt.cpp +++ b/llvm/lib/Transforms/IPO/GlobalOpt.cpp @@ -23,6 +23,7 @@ #include "llvm/Module.h" #include "llvm/Pass.h" #include "llvm/Analysis/ConstantFolding.h" +#include "llvm/Transforms/Utils/Local.h" #include "llvm/Target/TargetData.h" #include "llvm/Support/CallSite.h" #include "llvm/Support/Compiler.h" @@ -1562,7 +1563,7 @@ static bool TryToShrinkGlobalToBoolean(GlobalVariable *GV, Constant *OtherVal) { // Walk the use list of the global seeing if all the uses are load or store. // If there is anything else, bail out. for (Value::use_iterator I = GV->use_begin(), E = GV->use_end(); I != E; ++I) - if (!isa(I) && !isa(I)) + if (!isa(I) && !isa(I) && !UserIsDebugInfo(*I)) return false; DOUT << " *** SHRINKING TO BOOL: " << *GV; @@ -1585,8 +1586,8 @@ static bool TryToShrinkGlobalToBoolean(GlobalVariable *GV, Constant *OtherVal) { IsOneZero = InitVal->isNullValue() && CI->isOne(); while (!GV->use_empty()) { - Instruction *UI = cast(GV->use_back()); - if (StoreInst *SI = dyn_cast(UI)) { + User *GVU = GV->use_back(); + if (StoreInst *SI = dyn_cast(GVU)) { // Change the store into a boolean store. bool StoringOther = SI->getOperand(0) == OtherVal; // Only do this if we weren't storing a loaded value. @@ -1614,9 +1615,9 @@ static bool TryToShrinkGlobalToBoolean(GlobalVariable *GV, Constant *OtherVal) { } } new StoreInst(StoreVal, NewGV, SI); - } else { + SI->eraseFromParent(); + } else if (LoadInst *LI = dyn_cast(GVU)) { // Change the load into a load of bool then a select. - LoadInst *LI = cast(UI); LoadInst *NLI = new LoadInst(NewGV, LI->getName()+".b", LI); Value *NSI; if (IsOneZero) @@ -1625,8 +1626,9 @@ static bool TryToShrinkGlobalToBoolean(GlobalVariable *GV, Constant *OtherVal) { NSI = SelectInst::Create(NLI, OtherVal, InitVal, "", LI); NSI->takeName(LI); LI->replaceAllUsesWith(NSI); - } - UI->eraseFromParent(); + LI->eraseFromParent(); + } else + RemoveDbgInfoUser(GVU); } GV->eraseFromParent(); -- cgit v1.2.3