From 992fc88111578d04b21ed1f9c5ade82a502423d5 Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Fri, 7 Dec 2018 19:29:00 +0000 Subject: [llvm-tapi] Don't try to override SequenceTraits for std::string For some reason this doesn't seem to work with LLVM_LINK_LLVM_DYLIB build. See https://logs.chromium.org/logs/chromium/bb/client.wasm.llvm/linux/37764/+/recipes/steps/LLVM_regression_tests/0/stdout What is more it seems that overriding these traits for core types (including std::string) is not supported/recommend by YAMLTraits.h. See line 1918 which has the assertion: "only use LLVM_YAML_IS_SEQUENCE_VECTOR for types you control" Differential Revision: https://reviews.llvm.org/D55381 llvm-svn: 348630 --- llvm/lib/TextAPI/ELF/TBEHandler.cpp | 17 ----------------- 1 file changed, 17 deletions(-) (limited to 'llvm/lib/TextAPI/ELF/TBEHandler.cpp') diff --git a/llvm/lib/TextAPI/ELF/TBEHandler.cpp b/llvm/lib/TextAPI/ELF/TBEHandler.cpp index a3216663729..846f80a8b5b 100644 --- a/llvm/lib/TextAPI/ELF/TBEHandler.cpp +++ b/llvm/lib/TextAPI/ELF/TBEHandler.cpp @@ -126,23 +126,6 @@ template <> struct CustomMappingTraits> { } }; -/// YAML traits for generic string vectors (i.e. list of needed libraries). -template <> struct SequenceTraits> { - static size_t size(IO &IO, std::vector &List) { - return List.size(); - } - - static std::string &element(IO &IO, std::vector &List, - size_t Index) { - if (Index >= List.size()) - List.resize(Index + 1); - return List[Index]; - } - - // Compacts list of needed libraries into a single line. - static const bool flow = true; -}; - /// YAML traits for ELFStub objects. template <> struct MappingTraits { static void mapping(IO &IO, ELFStub &Stub) { -- cgit v1.2.3