From 60f3b73e1119d985732c70df930deac9c45b205c Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Sat, 25 Jul 2009 18:57:34 +0000 Subject: this is (unfortunately) several changes mixed together: 1. Spell SectionFlags::Writeable as "Writable". 2. Add predicates for deriving SectionFlags from SectionKinds. 3. Sink ELF-specific getSectionPrefixForUniqueGlobal impl into ELFTargetAsmInfo. 4. Fix SectionFlagsForGlobal to know that BSS/ThreadBSS has the BSS bit set (the real fix for PR4619). 5. Fix isSuitableForBSS to not put globals with explicit sections set in BSS (which was the reason #4 wasn't fixed earlier). 6. Remove my previous hack for PR4619. llvm-svn: 77085 --- llvm/lib/Target/X86/X86TargetAsmInfo.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'llvm/lib/Target/X86/X86TargetAsmInfo.cpp') diff --git a/llvm/lib/Target/X86/X86TargetAsmInfo.cpp b/llvm/lib/Target/X86/X86TargetAsmInfo.cpp index 3dc7ec4b4fa..e71cd70a3d1 100644 --- a/llvm/lib/Target/X86/X86TargetAsmInfo.cpp +++ b/llvm/lib/Target/X86/X86TargetAsmInfo.cpp @@ -282,7 +282,6 @@ getSectionPrefixForUniqueGlobal(SectionKind::Kind Kind) const { case SectionKind::RODataMergeConst: case SectionKind::RODataMergeStr: return ".rdata$linkonce"; } - return NULL; } std::string X86COFFTargetAsmInfo::printSectionFlags(unsigned flags) const { @@ -290,7 +289,7 @@ std::string X86COFFTargetAsmInfo::printSectionFlags(unsigned flags) const { if (flags & SectionFlags::Code) Flags += 'x'; - if (flags & SectionFlags::Writeable) + if (flags & SectionFlags::Writable) Flags += 'w'; Flags += "\""; @@ -322,7 +321,7 @@ X86WinTargetAsmInfo::X86WinTargetAsmInfo(const X86TargetMachine &TM): AlignmentIsInBytes = true; TextSection = getUnnamedSection("_text", SectionFlags::Code); - DataSection = getUnnamedSection("_data", SectionFlags::Writeable); + DataSection = getUnnamedSection("_data", SectionFlags::Writable); JumpTableDataSection = NULL; SwitchToSectionDirective = ""; -- cgit v1.2.3