From 18c56a07623e496480854f4927bcf1ba5213d177 Mon Sep 17 00:00:00 2001 From: Heejin Ahn Date: Mon, 4 Feb 2019 19:13:39 +0000 Subject: [WebAssembly] clang-tidy (NFC) Summary: This patch fixes clang-tidy warnings on wasm-only files. The list of checks used is: `-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,readability-identifier-naming,modernize-*` (LLVM's default .clang-tidy list is the same except it does not have `modernize-*`. But I've seen in multiple CLs in LLVM the modernize style was recommended and code was fixed based on the style, so I added it as well.) The common fixes are: - Variable names start with an uppercase letter - Function names start with a lowercase letter - Use `auto` when you use casts so the type is evident - Use inline initialization for class member variables - Use `= default` for empty constructors / destructors - Use `using` in place of `typedef` Reviewers: sbc100, tlively, aardappel Subscribers: dschuff, sunfish, jgravelle-google, yurydelendik, kripken, MatzeB, mgorny, rupprecht, llvm-commits Differential Revision: https://reviews.llvm.org/D57500 llvm-svn: 353075 --- llvm/lib/Target/WebAssembly/WebAssemblyLowerGlobalDtors.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'llvm/lib/Target/WebAssembly/WebAssemblyLowerGlobalDtors.cpp') diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyLowerGlobalDtors.cpp b/llvm/lib/Target/WebAssembly/WebAssemblyLowerGlobalDtors.cpp index e8707d14bfd..72e0c33e1e0 100644 --- a/llvm/lib/Target/WebAssembly/WebAssemblyLowerGlobalDtors.cpp +++ b/llvm/lib/Target/WebAssembly/WebAssemblyLowerGlobalDtors.cpp @@ -69,7 +69,7 @@ bool LowerGlobalDtors::runOnModule(Module &M) { return false; // Sanity-check @llvm.global_dtor's type. - StructType *ETy = dyn_cast(InitList->getType()->getElementType()); + auto *ETy = dyn_cast(InitList->getType()->getElementType()); if (!ETy || ETy->getNumElements() != 3 || !ETy->getTypeAtIndex(0U)->isIntegerTy() || !ETy->getTypeAtIndex(1U)->isPointerTy() || @@ -80,11 +80,11 @@ bool LowerGlobalDtors::runOnModule(Module &M) { // associated symbol. std::map>> DtorFuncs; for (Value *O : InitList->operands()) { - ConstantStruct *CS = dyn_cast(O); + auto *CS = dyn_cast(O); if (!CS) continue; // Malformed. - ConstantInt *Priority = dyn_cast(CS->getOperand(0)); + auto *Priority = dyn_cast(CS->getOperand(0)); if (!Priority) continue; // Malformed. uint16_t PriorityValue = Priority->getLimitedValue(UINT16_MAX); -- cgit v1.2.3