From 98432956087f564dd39fe8d76aa6bc5fc09e079b Mon Sep 17 00:00:00 2001 From: Wouter van Oortmerssen Date: Thu, 3 Jan 2019 22:59:59 +0000 Subject: [WebAssembly] Made InstPrinter more robust Summary: Instead of asserting on certain kinds of malformed instructions, it now still print, but instead adds an annotation indicating the problem, and/or indicates invalid_type etc. We're using the InstPrinter from many contexts that can't always guarantee values are within range (e.g. the disassembler), where having output is more valueable than asserting. Reviewers: dschuff, aheejin Subscribers: sbc100, jgravelle-google, sunfish, llvm-commits Differential Revision: https://reviews.llvm.org/D56223 llvm-svn: 350365 --- .../WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.cpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.cpp') diff --git a/llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.cpp b/llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.cpp index 70ac5027254..50143fb0ece 100644 --- a/llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.cpp +++ b/llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.cpp @@ -47,7 +47,7 @@ static void printTypes(formatted_raw_ostream &OS, First = false; else OS << ", "; - OS << WebAssembly::TypeToString(Type); + OS << WebAssembly::typeToString(Type); } OS << '\n'; } @@ -76,7 +76,7 @@ void WebAssemblyTargetAsmStreamer::emitParamList( for (auto &Ty : Params) { if (&Ty != &Params[0]) OS << ", "; - OS << WebAssembly::TypeToString(Ty); + OS << WebAssembly::typeToString(Ty); } } @@ -86,7 +86,7 @@ void WebAssemblyTargetAsmStreamer::emitReturnList( for (auto &Ty : Returns) { if (&Ty != &Returns[0]) OS << ", "; - OS << WebAssembly::TypeToString(Ty); + OS << WebAssembly::typeToString(Ty); } } @@ -99,10 +99,10 @@ void WebAssemblyTargetAsmStreamer::emitFunctionType(const MCSymbolWasm *Sym) { void WebAssemblyTargetAsmStreamer::emitGlobalType(const MCSymbolWasm *Sym) { assert(Sym->isGlobal()); - OS << "\t.globaltype\t" << Sym->getName() << ", " << - WebAssembly::TypeToString( - static_cast(Sym->getGlobalType().Type)) << - '\n'; + OS << "\t.globaltype\t" << Sym->getName() << ", " + << WebAssembly::typeToString( + static_cast(Sym->getGlobalType().Type)) + << '\n'; } void WebAssemblyTargetAsmStreamer::emitEventType(const MCSymbolWasm *Sym) { -- cgit v1.2.3