From da018e5687a8694585d20db87ee135c0638e14bf Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Fri, 27 Apr 2018 00:21:34 +0000 Subject: [MachineOutliner] Don't outline from functions with a section marking. The program might have unusual expectations for functions; for example, the Linux kernel's build system warns if it finds references from .text to .init.data. I'm not sure this is something we actually want to make any guarantees about (there isn't any explicit rule that would disallow outlining in this case), but we might want to be conservative anyway. Differential Revision: https://reviews.llvm.org/D46091 llvm-svn: 331007 --- llvm/lib/Target/AArch64/AArch64InstrInfo.cpp | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'llvm/lib/Target/AArch64') diff --git a/llvm/lib/Target/AArch64/AArch64InstrInfo.cpp b/llvm/lib/Target/AArch64/AArch64InstrInfo.cpp index 6de4bb2143d..ee81c16c260 100644 --- a/llvm/lib/Target/AArch64/AArch64InstrInfo.cpp +++ b/llvm/lib/Target/AArch64/AArch64InstrInfo.cpp @@ -4989,6 +4989,13 @@ bool AArch64InstrInfo::isFunctionSafeToOutlineFrom( if (!OutlineFromLinkOnceODRs && F.hasLinkOnceODRLinkage()) return false; + // Don't outline from functions with section markings; the program could + // expect that all the code is in the named section. + // FIXME: Allow outlining from multiple functions with the same section + // marking. + if (F.hasSection()) + return false; + // Outlining from functions with redzones is unsafe since the outliner may // modify the stack. Check if hasRedZone is true or unknown; if yes, don't // outline from it. -- cgit v1.2.3