From 486df738c305eeb148d557a94777f2c04aa72d40 Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Mon, 16 Jan 2012 23:24:27 +0000 Subject: Removing unused default switch cases in switches over enums that already account for all enumeration values explicitly. (This time I believe I've checked all the -Wreturn-type warnings from GCC & added the couple of llvm_unreachables necessary to silence them. If I've missed any, I'll happily fix them as soon as I know about them) llvm-svn: 148262 --- llvm/lib/Support/CommandLine.cpp | 6 ------ llvm/lib/Support/SourceMgr.cpp | 1 - 2 files changed, 7 deletions(-) (limited to 'llvm/lib/Support') diff --git a/llvm/lib/Support/CommandLine.cpp b/llvm/lib/Support/CommandLine.cpp index ce9344954bc..d1f9fad8dd4 100644 --- a/llvm/lib/Support/CommandLine.cpp +++ b/llvm/lib/Support/CommandLine.cpp @@ -292,12 +292,6 @@ static inline bool ProvideOption(Option *Handler, StringRef ArgName, break; case ValueOptional: break; - - default: - errs() << ProgramName - << ": Bad ValueMask flag! CommandLine usage error:" - << Handler->getValueExpectedFlag() << "\n"; - llvm_unreachable(0); } // If this isn't a multi-arg option, just run the handler. diff --git a/llvm/lib/Support/SourceMgr.cpp b/llvm/lib/Support/SourceMgr.cpp index 5a6090d05e3..bbe36b260b9 100644 --- a/llvm/lib/Support/SourceMgr.cpp +++ b/llvm/lib/Support/SourceMgr.cpp @@ -244,7 +244,6 @@ void SMDiagnostic::print(const char *ProgName, raw_ostream &S) const { } switch (Kind) { - default: assert(0 && "Unknown diagnostic kind"); case SourceMgr::DK_Error: S << "error: "; break; case SourceMgr::DK_Warning: S << "warning: "; break; case SourceMgr::DK_Note: S << "note: "; break; -- cgit v1.2.3