From 17388a61b270a21ee711cd51e003c17d2b3bdf29 Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Mon, 3 Mar 2014 18:02:34 +0000 Subject: Revert "[C++11] Replace LLVM atomics with std::atomic." Breaks the MSVC build. DataStream.cpp(44): error C2552: 'llvm::Statistic::Value' : non-aggregates cannot be initialized with initializer list llvm-svn: 202731 --- llvm/lib/Support/ManagedStatic.cpp | 3 ++- llvm/lib/Support/Statistic.cpp | 2 +- llvm/lib/Support/Threading.cpp | 6 +++--- llvm/lib/Support/Timer.cpp | 4 ++-- 4 files changed, 8 insertions(+), 7 deletions(-) (limited to 'llvm/lib/Support') diff --git a/llvm/lib/Support/ManagedStatic.cpp b/llvm/lib/Support/ManagedStatic.cpp index c19f8cb4859..098cccb68df 100644 --- a/llvm/lib/Support/ManagedStatic.cpp +++ b/llvm/lib/Support/ManagedStatic.cpp @@ -13,6 +13,7 @@ #include "llvm/Support/ManagedStatic.h" #include "llvm/Config/config.h" +#include "llvm/Support/Atomic.h" #include using namespace llvm; @@ -27,7 +28,7 @@ void ManagedStaticBase::RegisterManagedStatic(void *(*Creator)(), void* tmp = Creator ? Creator() : 0; TsanHappensBefore(this); - std::atomic_thread_fence(std::memory_order_seq_cst); + sys::MemoryFence(); // This write is racy against the first read in the ManagedStatic // accessors. The race is benign because it does a second read after a diff --git a/llvm/lib/Support/Statistic.cpp b/llvm/lib/Support/Statistic.cpp index 9d075736b30..56c3b0f5659 100644 --- a/llvm/lib/Support/Statistic.cpp +++ b/llvm/lib/Support/Statistic.cpp @@ -76,7 +76,7 @@ void Statistic::RegisterStatistic() { StatInfo->addStatistic(this); TsanHappensBefore(this); - std::atomic_thread_fence(std::memory_order_seq_cst); + sys::MemoryFence(); // Remember we have been registered. TsanIgnoreWritesBegin(); Initialized = true; diff --git a/llvm/lib/Support/Threading.cpp b/llvm/lib/Support/Threading.cpp index 15dd8a98052..9d7ac6c18de 100644 --- a/llvm/lib/Support/Threading.cpp +++ b/llvm/lib/Support/Threading.cpp @@ -13,8 +13,8 @@ #include "llvm/Support/Threading.h" #include "llvm/Config/config.h" +#include "llvm/Support/Atomic.h" #include "llvm/Support/Mutex.h" -#include #include using namespace llvm; @@ -31,7 +31,7 @@ bool llvm::llvm_start_multithreaded() { // We fence here to ensure that all initialization is complete BEFORE we // return from llvm_start_multithreaded(). - std::atomic_thread_fence(std::memory_order_seq_cst); + sys::MemoryFence(); return true; #else return false; @@ -44,7 +44,7 @@ void llvm::llvm_stop_multithreaded() { // We fence here to insure that all threaded operations are complete BEFORE we // return from llvm_stop_multithreaded(). - std::atomic_thread_fence(std::memory_order_seq_cst); + sys::MemoryFence(); multithreaded_mode = false; delete global_lock; diff --git a/llvm/lib/Support/Timer.cpp b/llvm/lib/Support/Timer.cpp index 03845f21f2d..0456f5d6383 100644 --- a/llvm/lib/Support/Timer.cpp +++ b/llvm/lib/Support/Timer.cpp @@ -81,14 +81,14 @@ raw_ostream *llvm::CreateInfoOutputFile() { static TimerGroup *DefaultTimerGroup = 0; static TimerGroup *getDefaultTimerGroup() { TimerGroup *tmp = DefaultTimerGroup; - std::atomic_thread_fence(std::memory_order_seq_cst); + sys::MemoryFence(); if (tmp) return tmp; llvm_acquire_global_lock(); tmp = DefaultTimerGroup; if (!tmp) { tmp = new TimerGroup("Miscellaneous Ungrouped Timers"); - std::atomic_thread_fence(std::memory_order_seq_cst); + sys::MemoryFence(); DefaultTimerGroup = tmp; } llvm_release_global_lock(); -- cgit v1.2.3