From 112ebb687a283825ddadebe938841c483534cba8 Mon Sep 17 00:00:00 2001 From: Bob Haarman Date: Thu, 2 Aug 2018 18:27:21 +0000 Subject: [Support] [NFC] change comment about retries in createUniqueEntity Rewording as requested on D50126 after the change was pushed. llvm-svn: 338755 --- llvm/lib/Support/Path.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'llvm/lib/Support') diff --git a/llvm/lib/Support/Path.cpp b/llvm/lib/Support/Path.cpp index adba21b3bcd..99c90d79551 100644 --- a/llvm/lib/Support/Path.cpp +++ b/llvm/lib/Support/Path.cpp @@ -190,8 +190,10 @@ createUniqueEntity(const Twine &Model, int &ResultFD, ResultPath.push_back(0); ResultPath.pop_back(); - // Limit the number of attempts we make, so that we don't infinite loop when - // we run out of filenames that fit the model. + // Limit the number of attempts we make, so that we don't infinite loop. E.g. + // "permission denied" could be for a specific file (so we retry with a + // different name) or for the whole directory (retry would always fail). + // Checking which is racy, so we try a number of times, then give up. std::error_code EC; for (int Retries = 128; Retries > 0; --Retries) { // Replace '%' with random chars. -- cgit v1.2.3