From e99dee82b0bd90e3f51482de3b18a4ae0e040eb6 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Fri, 12 Jul 2019 16:23:25 +0000 Subject: [Support] Move the static initializer install_out_memory_new_handler to InitLLVM An application linking against LLVMSupport should not get the gratuitous set::std_new_handler call. Reviewed By: jfb Differential Revision: https://reviews.llvm.org/D64505 llvm-svn: 365915 --- llvm/lib/Support/ErrorHandling.cpp | 22 +++++----------------- 1 file changed, 5 insertions(+), 17 deletions(-) (limited to 'llvm/lib/Support/ErrorHandling.cpp') diff --git a/llvm/lib/Support/ErrorHandling.cpp b/llvm/lib/Support/ErrorHandling.cpp index 27b48670ac0..0f13f7a536f 100644 --- a/llvm/lib/Support/ErrorHandling.cpp +++ b/llvm/lib/Support/ErrorHandling.cpp @@ -186,25 +186,13 @@ static void out_of_memory_new_handler() { llvm::report_bad_alloc_error("Allocation failed"); } -// Installs new handler that causes crash on allocation failure. It does not -// need to be called explicitly, if this file is linked to application, because -// in this case it is called during construction of 'new_handler_installer'. +// Installs new handler that causes crash on allocation failure. It is called by +// InitLLVM. void llvm::install_out_of_memory_new_handler() { - static bool out_of_memory_new_handler_installed = false; - if (!out_of_memory_new_handler_installed) { - std::set_new_handler(out_of_memory_new_handler); - out_of_memory_new_handler_installed = true; - } + std::new_handler old = std::set_new_handler(out_of_memory_new_handler); + (void)old; + assert(old == nullptr && "new-handler already installed"); } - -// Static object that causes installation of 'out_of_memory_new_handler' before -// execution of 'main'. -static class NewHandlerInstaller { -public: - NewHandlerInstaller() { - install_out_of_memory_new_handler(); - } -} new_handler_installer; #endif void llvm::llvm_unreachable_internal(const char *msg, const char *file, -- cgit v1.2.3