From 3f8ed9e1ae80f25d538d1baa46f5e89c3e72b8f6 Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Tue, 26 Jan 2010 15:56:18 +0000 Subject: Fix a typo that several people pointed out. Also, address the case of wrapping that Duncan pointed out. llvm-svn: 94547 --- llvm/lib/Support/ConstantRange.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'llvm/lib/Support/ConstantRange.cpp') diff --git a/llvm/lib/Support/ConstantRange.cpp b/llvm/lib/Support/ConstantRange.cpp index e9ddffc06ba..2746f7aaaa5 100644 --- a/llvm/lib/Support/ConstantRange.cpp +++ b/llvm/lib/Support/ConstantRange.cpp @@ -540,8 +540,10 @@ ConstantRange::add(const ConstantRange &Other) const { ConstantRange ConstantRange::multiply(const ConstantRange &Other) const { - // TODO: If either operand is a single element, round the result min anx - // max value to the appropriate multiple of that element. + // TODO: If either operand is a single element and the multiply is known to + // be non-wrapping, round the result min and max value to the appropriate + // multiple of that element. If wrapping is possible, at least adjust the + // range according to the greatest power-of-two factor of the single element. if (isEmptySet() || Other.isEmptySet()) return ConstantRange(getBitWidth(), /*isFullSet=*/false); -- cgit v1.2.3