From 34e4e477c869f0e4f69935defba0eba5a1a7c3f4 Mon Sep 17 00:00:00 2001 From: Vedant Kumar Date: Wed, 29 Jun 2016 05:33:26 +0000 Subject: Revert "[Coverage] Move logic to encode filenames and mappings into llvm (NFC)" This reverts commit 520a8298d8ef676b5da617ba3d2c7fa37381e939 (r273055). This is breaking stage2 instrumented builds with "malformed coverage data" errors. llvm-svn: 274106 --- .../ProfileData/Coverage/CoverageMappingWriter.cpp | 57 +++------------------- 1 file changed, 8 insertions(+), 49 deletions(-) (limited to 'llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp') diff --git a/llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp b/llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp index 4ac3ab3311c..8ff90d62cfd 100644 --- a/llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp +++ b/llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp @@ -18,6 +18,14 @@ using namespace llvm; using namespace coverage; +void CoverageFilenamesSectionWriter::write(raw_ostream &OS) { + encodeULEB128(Filenames.size(), OS); + for (const auto &Filename : Filenames) { + encodeULEB128(Filename.size(), OS); + OS << Filename; + } +} + namespace { /// \brief Gather only the expressions that are used by the mapping /// regions in this function. @@ -173,52 +181,3 @@ void CoverageMappingWriter::write(raw_ostream &OS) { // Ensure that all file ids have at least one mapping region. assert(CurrentFileID == (VirtualFileMapping.size() - 1)); } - -/// \brief Encode coverage data into \p OS. -static void encodeCoverageData(ArrayRef Filenames, - ArrayRef CoverageMappings, - size_t &FilenamesSize, - size_t &CoverageMappingsSize, raw_ostream &OS) { - size_t OSOffset = OS.GetNumBytesInBuffer(); - - // Encode the filenames. - encodeULEB128(Filenames.size(), OS); - for (const auto &Filename : Filenames) { - encodeULEB128(Filename.size(), OS); - OS << Filename; - } - - FilenamesSize = OS.GetNumBytesInBuffer() - OSOffset; - - // Encode the coverage mappings. - for (const auto &RawMapping : CoverageMappings) - OS << RawMapping; - - // Pad the output stream to an 8-byte boundary. Account for the padding bytes - // in \p CoverageMappingsSize. - if (size_t Rem = OS.GetNumBytesInBuffer() % 8) { - CoverageMappingsSize += 8 - Rem; - for (size_t I = 0, S = 8 - Rem; I < S; ++I) - OS << '\0'; - } - - CoverageMappingsSize = OS.GetNumBytesInBuffer() - FilenamesSize - OSOffset; -} - -namespace llvm { -namespace coverage { - -Expected encodeFilenamesAndRawMappings( - ArrayRef Filenames, ArrayRef CoverageMappings, - size_t &FilenamesSize, size_t &CoverageMappingsSize) { - std::string CoverageData; - { - raw_string_ostream OS{CoverageData}; - encodeCoverageData(Filenames, CoverageMappings, FilenamesSize, - CoverageMappingsSize, OS); - } - return std::move(CoverageData); -} - -} // end namespace coverage -} // end namespace llvm -- cgit v1.2.3