From 8c209aa8779de57771b64896f805e14cc0016dcd Mon Sep 17 00:00:00 2001 From: Matthias Braun Date: Sat, 28 Jan 2017 02:02:38 +0000 Subject: Cleanup dump() functions. We had various variants of defining dump() functions in LLVM. Normalize them (this should just consistently implement the things discussed in http://lists.llvm.org/pipermail/cfe-dev/2014-January/034323.html For reference: - Public headers should just declare the dump() method but not use LLVM_DUMP_METHOD or #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) - The definition of a dump method should look like this: #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) LLVM_DUMP_METHOD void MyClass::dump() { // print stuff to dbgs()... } #endif llvm-svn: 293359 --- llvm/lib/Option/Option.cpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'llvm/lib/Option/Option.cpp') diff --git a/llvm/lib/Option/Option.cpp b/llvm/lib/Option/Option.cpp index 5eb179fbd25..736b939fe80 100644 --- a/llvm/lib/Option/Option.cpp +++ b/llvm/lib/Option/Option.cpp @@ -83,7 +83,9 @@ void Option::print(raw_ostream &O) const { O << ">\n"; } +#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) LLVM_DUMP_METHOD void Option::dump() const { print(dbgs()); } +#endif bool Option::matches(OptSpecifier Opt) const { // Aliases are never considered in matching, look through them. -- cgit v1.2.3