From c63c1a72dab96b0d090b2601eb1e7f40df2db534 Mon Sep 17 00:00:00 2001 From: diggerlin Date: Thu, 7 Nov 2019 11:51:34 -0500 Subject: Using crtp to refactor the xcoff section header SUMMARY: According to https://reviews.llvm.org/D68575#inline-617586, Create a NFC patch for it. Using crtp to refactor the xcoff section header Move the define of SectionFlagsReservedMask and SectionFlagsTypeMask from XCOFFDumper.cpp to XCOFFObjectFile.h Reviewers: hubert.reinterpretcast,jasonliu Subscribers: rupprecht, seiyai,hiraditya Differential Revision: https://reviews.llvm.org/D69131 --- llvm/lib/Object/XCOFFObjectFile.cpp | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-) (limited to 'llvm/lib/Object') diff --git a/llvm/lib/Object/XCOFFObjectFile.cpp b/llvm/lib/Object/XCOFFObjectFile.cpp index 98782c2701c..6f1d999bc20 100644 --- a/llvm/lib/Object/XCOFFObjectFile.cpp +++ b/llvm/lib/Object/XCOFFObjectFile.cpp @@ -46,6 +46,25 @@ static StringRef generateXCOFFFixedNameStringRef(const char *Name) { : StringRef(Name, XCOFF::NameSize); } +// Explictly instantiate template classes. +template struct XCOFFSectionHeader; +template struct XCOFFSectionHeader; + +template StringRef XCOFFSectionHeader::getName() const { + const T &DerivedXCOFFSectionHeader = static_cast(*this); + return generateXCOFFFixedNameStringRef(DerivedXCOFFSectionHeader.Name); +} + +template uint16_t XCOFFSectionHeader::getSectionType() const { + const T &DerivedXCOFFSectionHeader = static_cast(*this); + return DerivedXCOFFSectionHeader.Flags & SectionFlagsTypeMask; +} + +template +bool XCOFFSectionHeader::isReservedSectionType() const { + return getSectionType() & SectionFlagsReservedMask; +} + bool XCOFFRelocation32::isRelocationSigned() const { return Info & XR_SIGN_INDICATOR_MASK; } @@ -688,14 +707,6 @@ ObjectFile::createXCOFFObjectFile(MemoryBufferRef MemBufRef, return XCOFFObjectFile::create(FileType, MemBufRef); } -StringRef XCOFFSectionHeader32::getName() const { - return generateXCOFFFixedNameStringRef(Name); -} - -StringRef XCOFFSectionHeader64::getName() const { - return generateXCOFFFixedNameStringRef(Name); -} - XCOFF::StorageClass XCOFFSymbolRef::getStorageClass() const { return OwningObjectPtr->toSymbolEntry(SymEntDataRef)->StorageClass; } -- cgit v1.2.3