From 7d0991953499174797b0ff94167bfec33e67ccfb Mon Sep 17 00:00:00 2001 From: Rui Ueyama Date: Tue, 9 Jun 2015 15:20:42 +0000 Subject: Remove object_error::success and use std::error_code() instead make_error_code(object_error) is slow because object::object_category() uses a ManagedStatic variable. But the real problem is that the function is called too frequently. This patch uses std::error_code() instead of object_error::success. In most cases, we return "success", so this patch reduces number of function calls to that function. http://reviews.llvm.org/D10333 llvm-svn: 239409 --- llvm/lib/Object/ObjectFile.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'llvm/lib/Object/ObjectFile.cpp') diff --git a/llvm/lib/Object/ObjectFile.cpp b/llvm/lib/Object/ObjectFile.cpp index 0950c7daafd..f6667d9ea6a 100644 --- a/llvm/lib/Object/ObjectFile.cpp +++ b/llvm/lib/Object/ObjectFile.cpp @@ -34,7 +34,7 @@ std::error_code ObjectFile::printSymbolName(raw_ostream &OS, if (std::error_code EC = getSymbolName(Symb, Name)) return EC; OS << Name; - return object_error::success; + return std::error_code(); } uint32_t ObjectFile::getSymbolAlignment(DataRefImpl DRI) const { return 0; } -- cgit v1.2.3