From d1af8fce0fa1d05d635eeb892b82f2cca1cee1cd Mon Sep 17 00:00:00 2001 From: Lang Hames Date: Fri, 25 Mar 2016 23:54:32 +0000 Subject: [Support] Switch to RAII helper for error-as-out-parameter idiom. As discussed on the llvm-commits thread for r264467. llvm-svn: 264479 --- llvm/lib/Object/MachOObjectFile.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'llvm/lib/Object/MachOObjectFile.cpp') diff --git a/llvm/lib/Object/MachOObjectFile.cpp b/llvm/lib/Object/MachOObjectFile.cpp index 864d76f7112..607c24688e4 100644 --- a/llvm/lib/Object/MachOObjectFile.cpp +++ b/llvm/lib/Object/MachOObjectFile.cpp @@ -246,7 +246,7 @@ static Error parseSegmentLoadCommand( Expected> MachOObjectFile::create(MemoryBufferRef Object, bool IsLittleEndian, bool Is64Bits) { - Error Err = Error::errorForOutParameter(); + Error Err; std::unique_ptr Obj( new MachOObjectFile(std::move(Object), IsLittleEndian, Is64Bits, Err)); @@ -262,7 +262,7 @@ MachOObjectFile::MachOObjectFile(MemoryBufferRef Object, bool IsLittleEndian, DataInCodeLoadCmd(nullptr), LinkOptHintsLoadCmd(nullptr), DyldInfoLoadCmd(nullptr), UuidLoadCmd(nullptr), HasPageZeroSegment(false) { - + ErrorAsOutParameter ErrAsOutParam(Err); if (is64Bit()) parseHeader(this, Header64, Err); else -- cgit v1.2.3