From 7d0991953499174797b0ff94167bfec33e67ccfb Mon Sep 17 00:00:00 2001 From: Rui Ueyama Date: Tue, 9 Jun 2015 15:20:42 +0000 Subject: Remove object_error::success and use std::error_code() instead make_error_code(object_error) is slow because object::object_category() uses a ManagedStatic variable. But the real problem is that the function is called too frequently. This patch uses std::error_code() instead of object_error::success. In most cases, we return "success", so this patch reduces number of function calls to that function. http://reviews.llvm.org/D10333 llvm-svn: 239409 --- llvm/lib/Object/Error.cpp | 1 - 1 file changed, 1 deletion(-) (limited to 'llvm/lib/Object/Error.cpp') diff --git a/llvm/lib/Object/Error.cpp b/llvm/lib/Object/Error.cpp index 5e4e237f4b0..644a178c162 100644 --- a/llvm/lib/Object/Error.cpp +++ b/llvm/lib/Object/Error.cpp @@ -33,7 +33,6 @@ const char *_object_error_category::name() const LLVM_NOEXCEPT { std::string _object_error_category::message(int EV) const { object_error E = static_cast(EV); switch (E) { - case object_error::success: return "Success"; case object_error::arch_not_found: return "No object file for requested architecture"; case object_error::invalid_file_type: -- cgit v1.2.3