From ed3ef4171173999be0f40e6fb7f5e60f5613b597 Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Wed, 19 Dec 2018 20:54:06 +0000 Subject: [llvm-ar] Simplify string table get-or-insert pattern with .insert, NFC llvm-svn: 349681 --- llvm/lib/Object/ArchiveWriter.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'llvm/lib/Object/ArchiveWriter.cpp') diff --git a/llvm/lib/Object/ArchiveWriter.cpp b/llvm/lib/Object/ArchiveWriter.cpp index 4de5871c7ec..da93602cbb2 100644 --- a/llvm/lib/Object/ArchiveWriter.cpp +++ b/llvm/lib/Object/ArchiveWriter.cpp @@ -268,14 +268,12 @@ static void printMemberHeader(raw_ostream &Out, uint64_t Pos, NamePos = StringTable.tell(); addToStringTable(StringTable, ArcName, M, Thin); } else { - StringMap::const_iterator it = MemberNames.find(M.MemberName); - if (it == MemberNames.end()) { - NamePos = StringTable.tell(); + auto Insertion = MemberNames.insert({M.MemberName, uint64_t(0)}); + if (Insertion.second) { + Insertion.first->second = StringTable.tell(); addToStringTable(StringTable, ArcName, M, Thin); - MemberNames[M.MemberName] = NamePos; - } else { - NamePos = it->second; } + NamePos = Insertion.first->second; } printWithSpacePadding(Out, NamePos, 15); printRestOfMemberHeader(Out, ModTime, M.UID, M.GID, M.Perms, Size); -- cgit v1.2.3