From 41af43092ccc8030bb49cea324d85eecd5ae68a8 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 11 Nov 2016 04:28:40 +0000 Subject: Make the Error class constructor protected This is forcing to use Error::success(), which is in a wide majority of cases a lot more readable. Differential Revision: https://reviews.llvm.org/D26481 llvm-svn: 286561 --- llvm/lib/Object/Archive.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'llvm/lib/Object/Archive.cpp') diff --git a/llvm/lib/Object/Archive.cpp b/llvm/lib/Object/Archive.cpp index 4684c186fb4..f2021f796d1 100644 --- a/llvm/lib/Object/Archive.cpp +++ b/llvm/lib/Object/Archive.cpp @@ -458,7 +458,7 @@ Expected Archive::Child::getNext() const { return malformedError(Msg + NameOrErr.get()); } - Error Err; + Error Err = Error::success(); Child Ret(Parent, NextLoc, &Err); if (Err) return std::move(Err); @@ -508,7 +508,7 @@ Archive::Child::getAsBinary(LLVMContext *Context) const { } Expected> Archive::create(MemoryBufferRef Source) { - Error Err; + Error Err = Error::success(); std::unique_ptr Ret(new Archive(Source, Err)); if (Err) return std::move(Err); @@ -830,7 +830,7 @@ Expected Archive::Symbol::getMember() const { } const char *Loc = Parent->getData().begin() + Offset; - Error Err; + Error Err = Error::success(); Child C(Parent, Loc, &Err); if (Err) return std::move(Err); -- cgit v1.2.3