From 75d65b9a03a04445fe0f6b13c4b6033bfb783c35 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Sat, 25 Sep 2010 05:42:19 +0000 Subject: Move ELF to HasReliableSymbolDifference=true. Also take the opportunity to put symbols defined in merge sections in independent atoms. llvm-svn: 114786 --- llvm/lib/MC/ELFObjectWriter.cpp | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) (limited to 'llvm/lib/MC/ELFObjectWriter.cpp') diff --git a/llvm/lib/MC/ELFObjectWriter.cpp b/llvm/lib/MC/ELFObjectWriter.cpp index 9eb9bcac46a..810af37c6c5 100644 --- a/llvm/lib/MC/ELFObjectWriter.cpp +++ b/llvm/lib/MC/ELFObjectWriter.cpp @@ -487,6 +487,13 @@ void ELFObjectWriterImpl::WriteSymbolTable(MCDataFragment *F, } } +static const MCSymbolData *getAtom(const MCSymbolData &SD) { + if (!SD.getFragment()) + return 0; + + return SD.getFragment()->getAtom(); +} + // FIXME: this is currently X86/X86_64 only void ELFObjectWriterImpl::RecordRelocation(const MCAssembler &Asm, const MCAsmLayout &Layout, @@ -502,7 +509,7 @@ void ELFObjectWriterImpl::RecordRelocation(const MCAssembler &Asm, if (!Target.isAbsolute()) { const MCSymbol *Symbol = &Target.getSymA()->getSymbol(); MCSymbolData &SD = Asm.getSymbolData(*Symbol); - const MCSymbolData *Base = Asm.getAtom(Layout, &SD); + const MCSymbolData *Base = getAtom(SD); MCFragment *F = SD.getFragment(); // Avoid relocations for cases like jumps and calls in the same file. @@ -515,7 +522,7 @@ void ELFObjectWriterImpl::RecordRelocation(const MCAssembler &Asm, } if (Base) { - if (F && !SD.isExternal()) { + if (Base != &SD) { Index = F->getParent()->getOrdinal() + LocalSymbolData.size() + 1; MCSectionData *FSD = F->getParent(); @@ -523,8 +530,6 @@ void ELFObjectWriterImpl::RecordRelocation(const MCAssembler &Asm, Value += Layout.getSymbolAddress(&SD) - Layout.getSectionAddress(FSD); } else Index = getSymbolIndexInSymbolTable(Asm, Symbol); - if (Base != &SD) - Value += Layout.getSymbolAddress(&SD) - Layout.getSymbolAddress(Base); Addend = Value; // Compensate for the addend on i386. if (Is64Bit) @@ -537,11 +542,14 @@ void ELFObjectWriterImpl::RecordRelocation(const MCAssembler &Asm, MCSectionData *FSD = F->getParent(); // Offset of the symbol in the section - Addend = Layout.getSymbolAddress(&SD) - Layout.getSectionAddress(FSD); + Value += Layout.getSymbolAddress(&SD) - Layout.getSectionAddress(FSD); } else { - FixedValue = Value; - return; + Index = getSymbolIndexInSymbolTable(Asm, Symbol); } + Addend = Value; + // Compensate for the addend on i386. + if (Is64Bit) + Value = 0; } } -- cgit v1.2.3