From 45eb84f34044c2e3c83f420c9bbdcdf028eb80c4 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Sun, 11 Nov 2018 01:46:03 +0000 Subject: [Support] Make error banner optional in logAllUnhandledErrors In a lot of places an empty string was passed as the ErrorBanner to logAllUnhandledErrors. This patch makes that argument optional to simplify the call sites. llvm-svn: 346604 --- llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldCOFF.cpp | 2 +- llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp | 6 +++--- llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.cpp | 2 +- llvm/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFThumb.h | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) (limited to 'llvm/lib/ExecutionEngine/RuntimeDyld') diff --git a/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldCOFF.cpp b/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldCOFF.cpp index 1c54ad6fb03..340ddaab186 100644 --- a/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldCOFF.cpp +++ b/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldCOFF.cpp @@ -66,7 +66,7 @@ RuntimeDyldCOFF::loadObject(const object::ObjectFile &O) { } else { HasError = true; raw_string_ostream ErrStream(ErrorStr); - logAllUnhandledErrors(ObjSectionToIDOrErr.takeError(), ErrStream, ""); + logAllUnhandledErrors(ObjSectionToIDOrErr.takeError(), ErrStream); return nullptr; } } diff --git a/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp b/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp index f9a81c7bd1b..226ee715e18 100644 --- a/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp +++ b/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp @@ -255,7 +255,7 @@ RuntimeDyldELF::loadObject(const object::ObjectFile &O) { else { HasError = true; raw_string_ostream ErrStream(ErrorStr); - logAllUnhandledErrors(ObjSectionToIDOrErr.takeError(), ErrStream, ""); + logAllUnhandledErrors(ObjSectionToIDOrErr.takeError(), ErrStream); return nullptr; } } @@ -1130,7 +1130,7 @@ RuntimeDyldELF::processRelocationRef( if (!SymTypeOrErr) { std::string Buf; raw_string_ostream OS(Buf); - logAllUnhandledErrors(SymTypeOrErr.takeError(), OS, ""); + logAllUnhandledErrors(SymTypeOrErr.takeError(), OS); OS.flush(); report_fatal_error(Buf); } @@ -1151,7 +1151,7 @@ RuntimeDyldELF::processRelocationRef( if (!SectionOrErr) { std::string Buf; raw_string_ostream OS(Buf); - logAllUnhandledErrors(SectionOrErr.takeError(), OS, ""); + logAllUnhandledErrors(SectionOrErr.takeError(), OS); OS.flush(); report_fatal_error(Buf); } diff --git a/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.cpp b/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.cpp index c5a215c8333..d47fcd45be8 100644 --- a/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.cpp +++ b/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.cpp @@ -370,7 +370,7 @@ RuntimeDyldMachO::loadObject(const object::ObjectFile &O) { else { HasError = true; raw_string_ostream ErrStream(ErrorStr); - logAllUnhandledErrors(ObjSectionToIDOrErr.takeError(), ErrStream, ""); + logAllUnhandledErrors(ObjSectionToIDOrErr.takeError(), ErrStream); return nullptr; } } diff --git a/llvm/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFThumb.h b/llvm/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFThumb.h index 729ea1ec48a..8723dd0fd0e 100644 --- a/llvm/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFThumb.h +++ b/llvm/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFThumb.h @@ -28,7 +28,7 @@ static bool isThumbFunc(symbol_iterator Symbol, const ObjectFile &Obj, if (!SymTypeOrErr) { std::string Buf; raw_string_ostream OS(Buf); - logAllUnhandledErrors(SymTypeOrErr.takeError(), OS, ""); + logAllUnhandledErrors(SymTypeOrErr.takeError(), OS); OS.flush(); report_fatal_error(Buf); } -- cgit v1.2.3