From c038e2db4d890969b016efc9a0f7c907c1fca19d Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Fri, 13 Nov 2015 17:00:36 +0000 Subject: [Symbolizer] Don't use PE symbol tables to override PDB symbols Summary: PE files are stripped by default, and only contain the names of exported symbols. The actual reason that we bother to do this override by default is actually due to a quirk of the way -gline-tables-only is implemented, so I phrased the check as "if we are symbolizing from dwarf, do the symtab override". This fixes lots of Windows ASan tests that I broke in r250582. Reviewers: samsonov Subscribers: llvm-commits Differential Revision: http://reviews.llvm.org/D14594 llvm-svn: 253051 --- llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.h | 3 +++ 1 file changed, 3 insertions(+) (limited to 'llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.h') diff --git a/llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.h b/llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.h index a90e95c376f..8583b6a36e6 100644 --- a/llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.h +++ b/llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.h @@ -43,6 +43,9 @@ public: uint64_t getModulePreferredBase() const override; private: + bool shouldOverrideWithSymbolTable(FunctionNameKind FNKind, + bool UseSymbolTable) const; + bool getNameFromSymbolTable(object::SymbolRef::Type Type, uint64_t Address, std::string &Name, uint64_t &Addr, uint64_t &Size) const; -- cgit v1.2.3