From 91567b6700ff7975cae34b28ec28b5281b33ff19 Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Tue, 1 Apr 2014 22:25:09 +0000 Subject: Fix accidental fallthrough in DebugLocEntry::hasSameValueOrLocation No test case (this would invoke UB by examining uninitialized members, etc, at best - and this code is apparently untested anyway - I'm about to fix that) Code review feedback from Adrian Prantl on r205360. llvm-svn: 205367 --- llvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) (limited to 'llvm/lib/CodeGen') diff --git a/llvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h b/llvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h index 9f5be6164f5..976edf0a2ab 100644 --- a/llvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h +++ b/llvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h @@ -46,18 +46,23 @@ class DebugLocEntry { if (EntryKind != Next.EntryKind) return false; + bool EqualValues; switch (EntryKind) { case E_Location: - if (Loc != Next.Loc) return false; + EqualValues = Loc == Next.Loc; + break; case E_Integer: - if (Constants.Int != Next.Constants.Int) return false; + EqualValues = Constants.Int == Next.Constants.Int; + break; case E_ConstantFP: - if (Constants.CFP != Next.Constants.CFP) return false; + EqualValues = Constants.CFP == Next.Constants.CFP; + break; case E_ConstantInt: - if (Constants.CIP != Next.Constants.CIP) return false; + EqualValues = Constants.CIP == Next.Constants.CIP; + break; } - return true; + return EqualValues; } public: -- cgit v1.2.3