From eac9e5ef212ba8892f8dfa79a3e9ef70e31779ca Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 20 Feb 2008 20:56:45 +0000 Subject: Remove one of the fixmes that I put in there. From Evan: No need to go up more levels. A def of a register also sets its sub-registers (so if PhysRegInfo[SuperReg] is NULL, it means SuperReg's super registers are not previously defined). llvm-svn: 47399 --- llvm/lib/CodeGen/LiveVariables.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'llvm/lib/CodeGen/LiveVariables.cpp') diff --git a/llvm/lib/CodeGen/LiveVariables.cpp b/llvm/lib/CodeGen/LiveVariables.cpp index 809048e8ef7..4b428d6f31c 100644 --- a/llvm/lib/CodeGen/LiveVariables.cpp +++ b/llvm/lib/CodeGen/LiveVariables.cpp @@ -258,8 +258,9 @@ void LiveVariables::HandlePhysRegUse(unsigned Reg, MachineInstr *MI) { bool HasPrevDef = PhysRegInfo[SuperReg] != NULL; if (!HasPrevDef) - // FIXME: This only goes back one level of super-registers. It might miss - // some. + // No need to go up more levels. A def of a register also sets its sub- + // registers. So if PhysRegInfo[SuperReg] is NULL, it means SuperReg's + // super-registers are not previously defined. for (const unsigned *SSRegs = RegInfo->getSuperRegisters(SuperReg); unsigned SSReg = *SSRegs; ++SSRegs) if (PhysRegInfo[SSReg] != NULL) { -- cgit v1.2.3