From 5ae6170fc29271ea76c18c09ef102f8613ae70fa Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 23 Dec 2016 02:20:09 +0000 Subject: MetadataLoader: Add an assertion for the implicit invariant of PlaceHolder while loading Metadata (NFC) llvm-svn: 290408 --- llvm/lib/Bitcode/Reader/MetadataLoader.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'llvm/lib/Bitcode/Reader/MetadataLoader.cpp') diff --git a/llvm/lib/Bitcode/Reader/MetadataLoader.cpp b/llvm/lib/Bitcode/Reader/MetadataLoader.cpp index 1cfa1a82182..93212b0aa77 100644 --- a/llvm/lib/Bitcode/Reader/MetadataLoader.cpp +++ b/llvm/lib/Bitcode/Reader/MetadataLoader.cpp @@ -372,8 +372,14 @@ DistinctMDOperandPlaceholder &PlaceholderQueue::getPlaceholderOp(unsigned ID) { void PlaceholderQueue::flush(BitcodeReaderMetadataList &MetadataList) { while (!PHs.empty()) { - PHs.front().replaceUseWith( - MetadataList.getMetadataFwdRef(PHs.front().getID())); + auto *MD = MetadataList.getMetadataFwdRef(PHs.front().getID()); +#ifndef NDEBUG + if (auto MDN = dyn_cast(MD)) { + assert(MDN->isResolved() && + "Flushing Placeholder while cycles aren't resolved"); + } +#endif + PHs.front().replaceUseWith(MD); PHs.pop_front(); } } -- cgit v1.2.3