From 4a5c8c602c68e727a0d560d68d6bf9463b2d3cc2 Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Fri, 13 Mar 2015 21:03:34 +0000 Subject: Turn assertion into bitcode reading error I don't think we test invalid bitcode records in any detail, so no test here - just a change for consistency with existing error checks in surrounding code. llvm-svn: 232215 --- llvm/lib/Bitcode/Reader/BitcodeReader.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'llvm/lib/Bitcode/Reader/BitcodeReader.cpp') diff --git a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp index c4e070cd17b..33b02f912f0 100644 --- a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp +++ b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp @@ -3126,8 +3126,8 @@ std::error_code BitcodeReader::ParseFunctionBody(Function *F) { } I = GetElementPtrInst::Create(BasePtr, GEPIdx); - (void)Ty; - assert(!Ty || Ty == cast(I)->getSourceElementType()); + if (Ty && Ty != cast(I)->getSourceElementType()) + return Error("Invalid record"); InstructionList.push_back(I); if (InBounds) cast(I)->setIsInBounds(true); -- cgit v1.2.3