From 98d281a99f1f60eac65ce348157dcec49742378f Mon Sep 17 00:00:00 2001 From: Hideto Ueno Date: Mon, 29 Jul 2019 13:35:34 +0000 Subject: [ValueTracking] Remove volatile check in isGuaranteedToTransferExecutionToSuccessor Summary: As clarified in D53184, volatile load and store do not trap. Therefore, we should remove volatile checks for instructions in `isGuaranteedToTransferExecutionToSuccessor`. Reviewers: jdoerfert, efriedma, nikic Reviewed By: nikic Subscribers: hiraditya, jfb, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D65375 llvm-svn: 367226 --- llvm/lib/Analysis/ValueTracking.cpp | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) (limited to 'llvm/lib/Analysis/ValueTracking.cpp') diff --git a/llvm/lib/Analysis/ValueTracking.cpp b/llvm/lib/Analysis/ValueTracking.cpp index c70906dcc62..4272f69ef81 100644 --- a/llvm/lib/Analysis/ValueTracking.cpp +++ b/llvm/lib/Analysis/ValueTracking.cpp @@ -4221,22 +4221,9 @@ OverflowResult llvm::computeOverflowForSignedAdd(const Value *LHS, } bool llvm::isGuaranteedToTransferExecutionToSuccessor(const Instruction *I) { - // A memory operation returns normally if it isn't volatile. A volatile - // operation is allowed to trap. - // - // An atomic operation isn't guaranteed to return in a reasonable amount of - // time because it's possible for another thread to interfere with it for an + // Note: An atomic operation isn't guaranteed to return in a reasonable amount + // of time because it's possible for another thread to interfere with it for an // arbitrary length of time, but programs aren't allowed to rely on that. - if (const LoadInst *LI = dyn_cast(I)) - return !LI->isVolatile(); - if (const StoreInst *SI = dyn_cast(I)) - return !SI->isVolatile(); - if (const AtomicCmpXchgInst *CXI = dyn_cast(I)) - return !CXI->isVolatile(); - if (const AtomicRMWInst *RMWI = dyn_cast(I)) - return !RMWI->isVolatile(); - if (const MemIntrinsic *MII = dyn_cast(I)) - return !MII->isVolatile(); // If there is no successor, then execution can't transfer to it. if (const auto *CRI = dyn_cast(I)) -- cgit v1.2.3