From d3a4cbe1537775ec89b4d4326f63bfdb6d53d903 Mon Sep 17 00:00:00 2001 From: Max Kazantsev Date: Thu, 30 Aug 2018 04:49:03 +0000 Subject: [NFC] Move OrderedInstructions and InstructionPrecedenceTracking to Analysis These classes don't make any changes to IR and have no reason to be in Transform/Utils. This patch moves them to Analysis folder. This will allow us reusing these classes in some analyzes, like MustExecute. llvm-svn: 341015 --- .../lib/Analysis/InstructionPrecedenceTracking.cpp | 99 ++++++++++++++++++++++ 1 file changed, 99 insertions(+) create mode 100644 llvm/lib/Analysis/InstructionPrecedenceTracking.cpp (limited to 'llvm/lib/Analysis/InstructionPrecedenceTracking.cpp') diff --git a/llvm/lib/Analysis/InstructionPrecedenceTracking.cpp b/llvm/lib/Analysis/InstructionPrecedenceTracking.cpp new file mode 100644 index 00000000000..7294e121507 --- /dev/null +++ b/llvm/lib/Analysis/InstructionPrecedenceTracking.cpp @@ -0,0 +1,99 @@ +//===-- InstructionPrecedenceTracking.cpp -----------------------*- C++ -*-===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// +// Implements a class that is able to define some instructions as "special" +// (e.g. as having implicit control flow, or writing memory, or having another +// interesting property) and then efficiently answers queries of the types: +// 1. Are there any special instructions in the block of interest? +// 2. Return first of the special instructions in the given block; +// 3. Check if the given instruction is preceeded by the first special +// instruction in the same block. +// The class provides caching that allows to answer these queries quickly. The +// user must make sure that the cached data is invalidated properly whenever +// a content of some tracked block is changed. +//===----------------------------------------------------------------------===// + +#include "llvm/Analysis/InstructionPrecedenceTracking.h" +#include "llvm/Analysis/ValueTracking.h" + +using namespace llvm; + +const Instruction *InstructionPrecedenceTracking::getFirstSpecialInstruction( + const BasicBlock *BB) { + if (!KnownBlocks.count(BB)) + fill(BB); + auto *FirstICF = FirstImplicitControlFlowInsts.lookup(BB); + assert((!FirstICF || FirstICF->getParent() == BB) && "Inconsistent cache!"); + return FirstICF; +} + +bool InstructionPrecedenceTracking::hasSpecialInstructions( + const BasicBlock *BB) { + return getFirstSpecialInstruction(BB) != nullptr; +} + +bool InstructionPrecedenceTracking::isPreceededBySpecialInstruction( + const Instruction *Insn) { + const Instruction *MaybeFirstICF = + getFirstSpecialInstruction(Insn->getParent()); + return MaybeFirstICF && OI.dominates(MaybeFirstICF, Insn); +} + +void InstructionPrecedenceTracking::fill(const BasicBlock *BB) { + FirstImplicitControlFlowInsts.erase(BB); + for (auto &I : *BB) + if (isSpecialInstruction(&I)) { + FirstImplicitControlFlowInsts[BB] = &I; + break; + } + + // Mark this block as having a known result. + KnownBlocks.insert(BB); +} + +void InstructionPrecedenceTracking::invalidateBlock(const BasicBlock *BB) { + OI.invalidateBlock(BB); + FirstImplicitControlFlowInsts.erase(BB); + KnownBlocks.erase(BB); +} + +void InstructionPrecedenceTracking::clear() { + for (auto It : FirstImplicitControlFlowInsts) + OI.invalidateBlock(It.first); + FirstImplicitControlFlowInsts.clear(); + KnownBlocks.clear(); +} + +bool ImplicitControlFlowTracking::isSpecialInstruction( + const Instruction *Insn) const { + // If a block's instruction doesn't always pass the control to its successor + // instruction, mark the block as having implicit control flow. We use them + // to avoid wrong assumptions of sort "if A is executed and B post-dominates + // A, then B is also executed". This is not true is there is an implicit + // control flow instruction (e.g. a guard) between them. + // + // TODO: Currently, isGuaranteedToTransferExecutionToSuccessor returns false + // for volatile stores and loads because they can trap. The discussion on + // whether or not it is correct is still ongoing. We might want to get rid + // of this logic in the future. Anyways, trapping instructions shouldn't + // introduce implicit control flow, so we explicitly allow them here. This + // must be removed once isGuaranteedToTransferExecutionToSuccessor is fixed. + if (isGuaranteedToTransferExecutionToSuccessor(Insn)) + return false; + if (isa(Insn)) { + assert(cast(Insn)->isVolatile() && + "Non-volatile load should transfer execution to successor!"); + return false; + } + if (isa(Insn)) { + assert(cast(Insn)->isVolatile() && + "Non-volatile store should transfer execution to successor!"); + return false; + } + return true; +} -- cgit v1.2.3