From 25ce596cd111ba93777338412ff9731b16f45cc6 Mon Sep 17 00:00:00 2001 From: James Henderson Date: Wed, 23 Jan 2019 17:27:48 +0000 Subject: [llvm-symbolizer] Improve compatibility of --functions with GNU addr2line This fixes https://bugs.llvm.org/show_bug.cgi?id=40072. GNU addr2line's --functions switch is off by default, has a short alias of -f, and does not take an argument. This patch changes llvm-symbolizer to allow the second and third point (changing the default behaviour may have negative impacts on users). If the option is missing a value, it now treats it as "linkage". This change does cause one previously valid command-line to behave differently. Before --functions was accepted, but now only --functions= is allowed (as well as --functions). The old behaviour will result in the value being treated as a positional argument. The previous testing for --functions=short has been pulled out into a new test that also tests the other accepted values and option formats. Reviewed by: ruiu Differential Revision: https://reviews.llvm.org/D57049 llvm-svn: 351968 --- llvm/docs/CommandGuide/llvm-symbolizer.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'llvm/docs/CommandGuide') diff --git a/llvm/docs/CommandGuide/llvm-symbolizer.rst b/llvm/docs/CommandGuide/llvm-symbolizer.rst index bfe8f3ee6bb..2e69a20442c 100644 --- a/llvm/docs/CommandGuide/llvm-symbolizer.rst +++ b/llvm/docs/CommandGuide/llvm-symbolizer.rst @@ -72,7 +72,7 @@ OPTIONS Path to object file to be symbolized. -.. option:: -functions=[none|short|linkage] +.. option:: -functions[=], -f Specify the way function names are printed (omit function name, print short function name, or print full linkage name, respectively). -- cgit v1.2.3