From 6aa13adf0e4effbdcd3b8d55f4622871d3627793 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Wed, 6 Dec 2017 18:33:07 +0000 Subject: [cmake] Remove unnecessary header include in atomics check The header include was required to work around PR19898, as noted in that comment. That PR has since been marked resolved fixed, and the configuration check passes without the header inclusion both when compiling on Windows with cl and when cross-compiling on Linux using clang-cl. I noticed this because the inclusion was cased incorrectly (Intrin.h instead of intrin.h), which when cross-compiling on a case sensitive file system would cause the intrin.h from the Windows SDK to be included (which LLVM can't handle) instead of the one from clang's resource directory, making the check fail. This is the same issue as r309980. Correcting the case of the inclusion makes the check pass when cross compiling, but it seems better to get rid of the inclusion entirely, since it appears to be unnecessary now. Differential Revision: https://reviews.llvm.org/D40910 llvm-svn: 319917 --- llvm/cmake/modules/CheckAtomic.cmake | 1 - 1 file changed, 1 deletion(-) (limited to 'llvm/cmake/modules/CheckAtomic.cmake') diff --git a/llvm/cmake/modules/CheckAtomic.cmake b/llvm/cmake/modules/CheckAtomic.cmake index 866eed08936..11f0366bc85 100644 --- a/llvm/cmake/modules/CheckAtomic.cmake +++ b/llvm/cmake/modules/CheckAtomic.cmake @@ -81,7 +81,6 @@ endif() ## assumes C++11 works. CHECK_CXX_SOURCE_COMPILES(" #ifdef _MSC_VER -#include /* Workaround for PR19898. */ #include #endif int main() { -- cgit v1.2.3