From 0e4c482124f098957fc13bcfbabc36775dd190ab Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 6 Mar 2019 21:22:25 +0000 Subject: Pass ConstString by value (NFC) My apologies for the large patch. With the exception of ConstString.h itself it was entirely produced by sed. ConstString has exactly one const char * data member, so passing a ConstString by reference is not any more efficient than copying it by value. In both cases a single pointer is passed. But passing it by value makes it harder to accidentally return the address of a local object. (This fixes rdar://problem/48640859 for the Apple folks) Differential Revision: https://reviews.llvm.org/D59030 llvm-svn: 355553 --- lldb/unittests/Core/MangledTest.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lldb/unittests/Core/MangledTest.cpp') diff --git a/lldb/unittests/Core/MangledTest.cpp b/lldb/unittests/Core/MangledTest.cpp index 4571b84e569..a9bef41b296 100644 --- a/lldb/unittests/Core/MangledTest.cpp +++ b/lldb/unittests/Core/MangledTest.cpp @@ -31,7 +31,7 @@ TEST(MangledTest, ResultForValidName) { bool IsMangled = true; Mangled TheMangled(MangledName, IsMangled); - const ConstString &TheDemangled = + ConstString TheDemangled = TheMangled.GetDemangledName(eLanguageTypeC_plus_plus); ConstString ExpectedResult("void a::b::c(unsigned long)"); @@ -43,7 +43,7 @@ TEST(MangledTest, EmptyForInvalidName) { bool IsMangled = true; Mangled TheMangled(MangledName, IsMangled); - const ConstString &TheDemangled = + ConstString TheDemangled = TheMangled.GetDemangledName(eLanguageTypeC_plus_plus); EXPECT_STREQ("", TheDemangled.GetCString()); -- cgit v1.2.3