From 13c7ad9cd245fca52773ac47e53da1cb46b38320 Mon Sep 17 00:00:00 2001 From: Robert Flack Date: Mon, 30 Mar 2015 14:12:17 +0000 Subject: Replace sys.platform skips in tests with @skip decorators which check against remote platform. Adds @skipIfPlatform and @skipUnlessPlatform decorators which will skip if / unless the target platform is in the provided platform list. Test Plan: ninja check-lldb shows no regressions. When running cross platform, tests which cannot run on the target platform are skipped. Differential Revision: http://reviews.llvm.org/D8665 llvm-svn: 233547 --- lldb/test/lang/cpp/dynamic-value/TestCppValueCast.py | 4 ++-- lldb/test/lang/cpp/dynamic-value/TestDynamicValue.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'lldb/test/lang/cpp/dynamic-value') diff --git a/lldb/test/lang/cpp/dynamic-value/TestCppValueCast.py b/lldb/test/lang/cpp/dynamic-value/TestCppValueCast.py index e3fbcfc2124..23a9fc503b8 100644 --- a/lldb/test/lang/cpp/dynamic-value/TestCppValueCast.py +++ b/lldb/test/lang/cpp/dynamic-value/TestCppValueCast.py @@ -13,7 +13,7 @@ class CppValueCastTestCase(TestBase): mydir = TestBase.compute_mydir(__file__) @unittest2.expectedFailure("rdar://problem/10808472 SBValue::Cast test case is failing (virtual inheritance)") - @unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin") + @skipUnlessDarwin @python_api_test @dsym_test def test_value_cast_with_dsym_and_virtual_inheritance(self): @@ -31,7 +31,7 @@ class CppValueCastTestCase(TestBase): self.setTearDownCleanup(dictionary=self.d_virtual) self.do_sbvalue_cast(self.exe_name) - @unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin") + @skipUnlessDarwin @python_api_test @dsym_test def test_value_cast_with_dsym_and_regular_inheritance(self): diff --git a/lldb/test/lang/cpp/dynamic-value/TestDynamicValue.py b/lldb/test/lang/cpp/dynamic-value/TestDynamicValue.py index 576d9642ebc..1de0a7b917f 100644 --- a/lldb/test/lang/cpp/dynamic-value/TestDynamicValue.py +++ b/lldb/test/lang/cpp/dynamic-value/TestDynamicValue.py @@ -12,7 +12,7 @@ class DynamicValueTestCase(TestBase): mydir = TestBase.compute_mydir(__file__) - @unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin") + @skipUnlessDarwin @python_api_test @dsym_test def test_get_dynamic_vals_with_dsym(self): -- cgit v1.2.3